Skip to content

Tensor statistic collection via NVIDIA-DLFW-Inspect & TE debug modules#3811

Open
paul-gibbons wants to merge 8 commits intoNVIDIA:mainfrom
paul-gibbons:pg/mr1-tensor-inspect
Open

Tensor statistic collection via NVIDIA-DLFW-Inspect & TE debug modules#3811
paul-gibbons wants to merge 8 commits intoNVIDIA:mainfrom
paul-gibbons:pg/mr1-tensor-inspect

Conversation

@paul-gibbons
Copy link
Copy Markdown
Contributor

What does this PR do ?

Adds support for NVIDIA DLFW Inspect into Megatron training loop, which enables the user to collect tensor statistics from TransformerEngine's debug modules.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 11, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@paul-gibbons paul-gibbons marked this pull request as ready for review March 17, 2026 17:01
@paul-gibbons paul-gibbons requested review from a team as code owners March 17, 2026 17:01
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 17, 2026 17:01
@ericharper
Copy link
Copy Markdown
Contributor

@paul-gibbons
Copy link
Copy Markdown
Contributor Author

How does this PR relate to what's in bridge? https://github.com/NVIDIA-NeMo/Megatron-Bridge/blob/6d8a1c547d2fc0a9d2812c3d6477fb0fca4d3714/src/megatron/bridge/training/tensor_inspect.py#L4

Brings the same functionality to MLM training loop.

Needed in MLM for further development of additional set of MRs to add tensor inspect modules inside of mcore

@ericharper
Copy link
Copy Markdown
Contributor

How does this PR relate to what's in bridge? https://github.com/NVIDIA-NeMo/Megatron-Bridge/blob/6d8a1c547d2fc0a9d2812c3d6477fb0fca4d3714/src/megatron/bridge/training/tensor_inspect.py#L4

Brings the same functionality to MLM training loop.

Needed in MLM for further development of additional set of MRs to add tensor inspect modules inside of mcore

Can consolidate this? @maanug-nv ? Maybe bridge gets this from mcore?

Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
@paul-gibbons paul-gibbons requested review from a team as code owners March 21, 2026 06:51
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Mar 25, 2026
@maanug-nv maanug-nv requested a review from jaredcasper March 30, 2026 23:43
Copy link
Copy Markdown
Contributor

@deepakn94 deepakn94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paul-gibbons Can you add some documentation on what the output of this looks like? You can add it somewhere here: https://github.com/NVIDIA/Megatron-LM/tree/main/docs. Screenshots, etc. useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants