Skip to content

Conversation

@shengliangxu
Copy link
Contributor

  1. start a new config system using yaml/yml files. The config system adopts Hydra style override, using the defaults tag, but we implement it by ourselves by simply merging the configs using OmegaConf

  2. implement the quantization configs using the new config system, but not actually in use.

  3. make sure the configs from the new config system match the exisiting configs

  4. pipe through config_file based hf_ptq script

  5. testted hf_ptq using both builtin and extenal config file

What does this PR do?

Type of change: ?

Overview: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

1. start a new config system using yaml/yml files. The config system
   adopts Hydra style override, using the defaults tag, but we implement
   it by ourselves by simply merging the configs using OmegaConf

2. implement the quantization configs using the new config system, but
   not actually in use.

3. make sure the configs from the new config system match the exisiting configs

4. pipe through config_file based hf_ptq script

5. testted hf_ptq using both builtin and extenal config file

Signed-off-by: Shengliang Xu <[email protected]>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 6, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 76.47059% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.52%. Comparing base (9409412) to head (c5f657e).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
modelopt/torch/opt/config.py 31.57% 13 Missing ⚠️
modelopt/torch/quantization/config.py 93.87% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   74.66%   74.52%   -0.15%     
==========================================
  Files         183      183              
  Lines       18550    18467      -83     
==========================================
- Hits        13851    13763      -88     
- Misses       4699     4704       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants