[5336829][AutoCast] Support subgraphs #659
Open
+393
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial bug mentioned conditional operators, but the issue can be generalized to any subgraph in the ONNX. Support by recursively traversing subgraphs in PrecisionConverter. Signed-off-by: Gal Hubara Agam <[email protected]>
Contributor
Author
|
/bot run |
galagam
requested review from
kevalmorabia97
and removed request for
gcunhase
kevalmorabia97
requested review from
ajrasane
and removed request for
kevalmorabia97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial bug mentioned conditional operators, but the issue can be generalized to any subgraph in the ONNX. Support by recursively traversing subgraphs in PrecisionConverter.
What does this PR do?
Type of change: ? Bug fix
Overview:
Initial bug mentioned conditional operators, but the issue can be generalized to any subgraph in the ONNX.
Support by recursively traversing subgraphs in PrecisionConverter.
Testing
Add unit tests with conditional
tests/unit/onnx/autocast/test_precisionconverter.py::model_with_if_subgraph
tests/unit/onnx/autocast/test_precisionconverter.py::test_if_subgraph_initializer_conversion
tests/unit/onnx/autocast/test_precisionconverter.py::test_if_subgraph_mixed_precision_boundary
Before your PR is "Ready for review"
Additional Information