-
Notifications
You must be signed in to change notification settings - Fork 231
Fix path for FedAvgRecipe #3934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/build |
Greptile OverviewGreptile SummaryUpdates import statements across experiment tracking examples and tests from Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Code as "Example/Test Code"
participant Init as "recipes/__init__.py"
participant FedAvg as "recipes/fedavg.py"
Note over Code,FedAvg: New Import Path (This PR)
Code->>FedAvg: "from nvflare.app_opt.pt.recipes.fedavg import FedAvgRecipe"
FedAvg-->>Code: "FedAvgRecipe class"
Note over Code,FedAvg: Old Import Path (Still works)
Code->>Init: "from nvflare.app_opt.pt.recipes import FedAvgRecipe"
Init->>FedAvg: "Re-export from fedavg module"
FedAvg-->>Init: "FedAvgRecipe class"
Init-->>Code: "FedAvgRecipe class"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR standardizes the import path for FedAvgRecipe across examples, tests, and documentation by changing from the implicit module-level import to the explicit submodule import path.
- Updates import statement from
from nvflare.app_opt.pt.recipes import FedAvgRecipetofrom nvflare.app_opt.pt.recipes.fedavg import FedAvgRecipe - Ensures consistency with the rest of the codebase which already uses the explicit import path
- Affects documentation, example code, and integration tests
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration_test/test_experiment_tracking_recipes.py | Updates FedAvgRecipe import path in integration test |
| examples/advanced/experiment-tracking/wandb/job.py | Updates FedAvgRecipe import path in WandB experiment tracking example |
| examples/advanced/experiment-tracking/wandb/README.md | Updates FedAvgRecipe import path in WandB documentation |
| examples/advanced/experiment-tracking/tensorboard/job.py | Updates FedAvgRecipe import path in TensorBoard experiment tracking example |
| examples/advanced/experiment-tracking/tensorboard/README.md | Updates FedAvgRecipe import path in TensorBoard documentation |
| examples/advanced/experiment-tracking/mlflow/hello-pt-mlflow/job.py | Updates FedAvgRecipe import path in MLflow PyTorch example |
| examples/advanced/experiment-tracking/mlflow/hello-pt-mlflow/README.md | Updates FedAvgRecipe import path in MLflow PyTorch documentation |
| examples/advanced/experiment-tracking/mlflow/hello-pt-mlflow-client/job.py | Updates FedAvgRecipe import path in MLflow client-side tracking example |
| examples/advanced/experiment-tracking/mlflow/hello-pt-mlflow-client/README.md | Updates FedAvgRecipe import path in MLflow client-side tracking documentation |
| examples/advanced/experiment-tracking/mlflow/hello-lightning-mlflow/job.py | Updates FedAvgRecipe import path in MLflow Lightning example |
| examples/advanced/experiment-tracking/mlflow/hello-lightning-mlflow/README.md | Updates FedAvgRecipe import path in MLflow Lightning documentation |
| examples/advanced/experiment-tracking/README.md | Updates FedAvgRecipe import path in experiment tracking overview documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Additional Comments (1)
|
|
/build |
Fix path for FedAvgRecipe.
Description
Fix path for FedAvgRecipe.
Types of changes
./runtest.sh.