Skip to content

fix embed stage ignoring pipeline endpoint - #1459

Merged
edknv merged 9 commits into
NVIDIA:mainfrom
edknv:edwardk/fix-config-embed
Mar 2, 2026
Merged

fix embed stage ignoring pipeline endpoint#1459
edknv merged 9 commits into
NVIDIA:mainfrom
edknv:edwardk/fix-config-embed

Conversation

@edknv

@edknv edknv commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes an error in the main nv-ingest pipeline:

No embedding endpoint configured (endpoint_url/embedding_nim_endpoint are empty) and no local embedder was provided in task_config['embedder']
  • Revert config lookups in embed_text.py that was introduced in Retriever #1427 to previoius state.
  • Flip if/elif priority to prefer local embedder over remote endpoint, removing the need to null out the endpoint to use a local embedder

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

@edknv
edknv requested a review from a team as a code owner March 2, 2026 16:51
@edknv
edknv requested a review from charlesbluca March 2, 2026 16:51
@edknv
edknv merged commit bd94408 into NVIDIA:main Mar 2, 2026
9 checks passed
jdye64 pushed a commit to jdye64/NeMo-Retriever that referenced this pull request May 19, 2026
Co-authored-by: Charles Blackmon-Luca <20627856+charlesbluca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants