(doc) remove the invalid -y flag from uv pip install openai quick-start command#1816
(doc) remove the invalid -y flag from uv pip install openai quick-start command#1816edknv merged 100 commits intoNVIDIA:mainfrom
Conversation
Update all hardcoded version references from 26.1.2 to 26.3.0-RC1 across helm charts, docker-compose, FastAPI, docs, and examples. Made-with: Cursor
…VIDIA#1577) Co-authored-by: Kurt Heiss <kheiss@nvidia.com>
Co-authored-by: Jeremy Dyer <jdye64@gmail.com>
…ing long VLM captioning Large PDFs with VLM captioning enabled can take 2-22+ hours depending on hardware. The previous defaults (STATE_TTL=7200s, RESULT_DATA_TTL=3600s) caused job state to expire mid-processing, resulting in 404 "Job ID not found or state has expired" errors even though the pipeline completed successfully. Raises both defaults to 172800s (48 hours), providing sufficient headroom for all observed workloads. Users can still override via RESULT_DATA_TTL_SECONDS and STATE_TTL_SECONDS environment variables. Fixes: Customer bug 5914605 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…t pipeline by removing references to deprecated PDF extractors and obsolete OCR API usage left over from the NeMo Retriever Library transition. (NVIDIA#1727)
Co-authored-by: sosahi <syousefisahi@nvidia.com>
…ine; misc README/Helm fixesUpdating files per bugs 5966185, 5966211, and 5966281 (NVIDIA#1742) Co-authored-by: sosahi <syousefisahi@nvidia.com>
Made-with: Cursor
…ll openai command: Greptile Summary This PR was explicitly created to remove the invalid -y flag from the uv pip install openai quick-start command (porting from PR NVIDIA#1812), but the fix was never committed — line 158 of nemo_retriever/README.md in the HEAD still reads uv pip install -y openai. P1 (nemo_retriever/README.md line 158): uv pip install -y openai remains unchanged; uv does not accept -y and the command will error for every user following the guide. Confidence Score: 4/5 Not safe to merge — the primary stated fix (removing -y) was not applied and the broken install command remains in the quick-start guide. One P1 finding remains: the uv pip install -y openai command on line 158 still carries the invalid -y flag. This will cause an unrecognized-option error for every user following the guide, which is the exact defect this PR was created to fix. nemo_retriever/README.md line 158 Vulnerabilities No security concerns identified. Important Files Changed Filename Overview nemo_retriever/README.md Quick-start README updated with CUDA 13 setup and pipeline examples; the stated fix (removing -y from uv pip install on line 158) was not applied — the invalid flag is still present. Flowchart %%{init: {'theme': 'neutral'}}%% flowchart TD A["User follows Quick Start guide"] --> B["uv pip install -y openai"] B --> C{"uv recognises -y flag?"} C -- No --> D["Error: unrecognized option '-y'\nInstall fails"] C -- Yes --> E["openai installed successfully"] D --> F["Fix: remove -y flag"] F --> G["uv pip install openai"] G --> E Loading Comments Outside Diff (1) nemo_retriever/README.md, line 158 (link) P1 Fix not applied — -y flag still present The PR title states this removes -y from the uv pip install command, but the HEAD commit on line 158 still reads uv pip install -y openai. The -y flag is an apt/apt-get convention; uv pip install does not recognise it and will exit with an unrecognized-option error for every user who copy-pastes this quick-start command. Prompt To Fix With AI This is a comment left during a code review. Path: nemo_retriever/README.md Line: 158 Comment: **Fix not applied — `-y` flag still present** The PR title states this removes `-y` from the `uv pip install` command, but the HEAD commit on line 158 still reads `uv pip install -y openai`. The `-y` flag is an `apt`/`apt-get` convention; `uv pip install` does not recognise it and will exit with an unrecognized-option error for every user who copy-pastes this quick-start command. How can I resolve this? If you propose a fix, please make it concise. Prompt To Fix All With AI This is a comment left during a code review. Path: nemo_retriever/README.md Line: 158 Comment: **Fix not applied — `-y` flag still present** The PR title states this removes `-y` from the `uv pip install` command, but the HEAD commit on line 158 still reads `uv pip install -y openai`. The `-y` flag is an `apt`/`apt-get` convention; `uv pip install` does not recognise it and will exit with an unrecognized-option error for every user who copy-pastes this quick-start command. ```suggestion uv pip install openai ```
Greptile SummaryThis PR fixes a broken quickstart instruction in
|
| Filename | Overview |
|---|---|
| nemo_retriever/README.md | Corrects broken install command (uv pip install -y openai → uv pip install openai); one minor prose inconsistency at line 203 remains |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["uv venv retriever --python 3.12"] --> B["uv pip install nemo-retriever nv-ingest-*"]
B --> C["uv pip install torch torchvision\n(CUDA 13 index)"]
C --> D[Run ingestion pipeline]
D --> E{Need LLM answers?}
E -- Yes --> F["uv pip install openai\nexport NVIDIA_API_KEY=..."]
F --> G["Query build.nvidia.com LLM\n(OpenAI-compatible API)"]
E -- No --> H["Query embeddings directly\nRetriever.query()"]
Comments Outside Diff (1)
-
nemo_retriever/README.md, line 203 (link)Inconsistent package manager reference in prose
This sentence uses
pip install cairosvgwhile every other install instruction in this guide usesuv pip. The code block immediately below already shows the correctuv pip installform — only this prose description needs updating.Prompt To Fix With AI
This is a comment left during a code review. Path: nemo_retriever/README.md Line: 203 Comment: **Inconsistent package manager reference in prose** This sentence uses `pip install cairosvg` while every other install instruction in this guide uses `uv pip`. The code block immediately below already shows the correct `uv pip install` form — only this prose description needs updating. How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: nemo_retriever/README.md
Line: 203
Comment:
**Inconsistent package manager reference in prose**
This sentence uses `pip install cairosvg` while every other install instruction in this guide uses `uv pip`. The code block immediately below already shows the correct `uv pip install` form — only this prose description needs updating.
```suggestion
For SVG files, install the optional `cairosvg` dependency with `uv pip install "cairosvg>=2.7.0"`. SVG support is available in the NeMo Retriever Library, but not in the container deployment. `cairosvg` requires network access to install, so it will not work in air-gapped environments.
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Merge branch 'main' into kheiss/remove-y..." | Re-trigger Greptile
|
Greptile Summary
Comment: The How can I resolve this? If you propose a fix, please make it concise. Comment: The |
removed -v option from pip install openai:
Since uv does not support -y, the command fails when users run the quick-start instructions.
Fix:
Replace the incorrect command with the proper one:
bash
uv pip install openai