-
Notifications
You must be signed in to change notification settings - Fork 42
Nemo-run Processor for TopIPL training #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
karpnv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add yaml config example and readme
|
Add a requirements file with all needed dependencies, including NeMo version |
7960435 to
1d1a351
Compare
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM. Thank you.
Please add copyright files where needed and pull changes from main.
And please fix DCO test
Signed-off-by: Nune <[email protected]>
271f1b0 to
f36dd60
Compare
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
|
Good morning Nune! |
|
git pull origin mian should fix tests |
karpnv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull the latest vertion in main to pass the tests
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: George Zelenfroind <[email protected]>
Jorjeous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config.rst
Please fix warnings in doctests related to file mentioned above
(line interval, etc)
Signed-off-by: George Zelenfroind <[email protected]>
Signed-off-by: George Zelenfroind <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
Signed-off-by: Nune <[email protected]>
|
I see that now we have some ubuntu related problems |
| nemo_directory (str): Base directory for NeMo framework | ||
| new_manifest_files (str, Optional): New manifest files to add to the training configuration | ||
| new_tarred_audio_filepaths (str, Optional): New tarred audio filepaths to add to the training configuration | ||
| **kwargs: Additional arguments passed to the parent BaseProcessor class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add example section
| num_gpus (int): Number of GPUs to use | ||
| is_tarred (bool): Whether the audio is tarred | ||
| first_run (bool): Whether this is the first run of pseudo-labeling | ||
| **kwargs: Additional arguments passed to the parent BaseProcessor class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add example section
like in this PR
https://github.com/NVIDIA/NeMo-speech-data-processor/pull/115/files#diff-424af7846bc8503aed8b73bc8e234ce9b50e7fa7ac6f1408cc5fdeedbd4c61b9
| config_path (str): Path to the YAML configuration file containing IPL settings | ||
| output_manifest_file (str): Path where the output manifest file will be written | ||
| input_manifest_file (str, Optional): Path to the input manifest file | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add example section
karpnv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
We forgot example section... |
Added three processors for training and inference command generation and one NeMo-Run processor specifically for IPL training.
Config file should be provided for NeMo-Run processor with the following parameters.