-
Notifications
You must be signed in to change notification settings - Fork 141
Future Implementations for classes - Measure, Money and Date #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
…nd Measure (#241) * Hindi TN changes Signed-off-by: Namrata Gachchi <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated date for Hindi TN cache Signed-off-by: Namrata Gachchi <[email protected]> * additional whitelist class .tsv files and unused imports removed Signed-off-by: Namrata Gachchi <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * incorporated suggestions for unused statements and another for closing the file opened Signed-off-by: Namrata Gachchi <[email protected]> * Combined Hindi TN and ITN seperate blocks into single Signed-off-by: Namrata Gachchi <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added init.py files and removed unused commented lines Signed-off-by: Namrata Gachchi <[email protected]> * commented irrevelant references and unused snippets from whitelist and word file Signed-off-by: Namrata Gachchi <[email protected]> * Whitelist and Word class changes Signed-off-by: Namrata Gachchi <[email protected]> * post processor changes with minor fixes Signed-off-by: Namrata Gachchi <[email protected]> * remove space before punctuation for sparrowhawk file Signed-off-by: Namrata Gachchi <[email protected]> * minor fixes for measure class Signed-off-by: Namrata Gachchi <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated Jenkinsfile Signed-off-by: Namrata Gachchi <[email protected]> * removed unused imports and statements Signed-off-by: Namrata Gachchi <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated date stamp for HI cache and commented ITN grammars Signed-off-by: Namrata Gachchi <[email protected]> * Updates the cache Signed-off-by: Simon Zuberek <[email protected]> * Disables Hindi ITN L0 checks Signed-off-by: Simon Zuberek <[email protected]> * Reapplies ITN CI Checks Signed-off-by: Simon Zuberek <[email protected]> * Adds missing inits Signed-off-by: Simon Zuberek <[email protected]> * resolved the failing sparrowhawk test cases failed Signed-off-by: Namrata Gachchi <[email protected]> --------- Signed-off-by: Namrata Gachchi <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
* ja tn Signed-off-by: Alex Cui <[email protected]> * adding ja Signed-off-by: Alex Cui <[email protected]> * removing Signed-off-by: Alex Cui <[email protected]> * updated tests Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addressing comment Signed-off-by: Alex Cui <[email protected]> * addressing ci Signed-off-by: Alex Cui <[email protected]> * addressing ci Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addresing comment Signed-off-by: Alex Cui <[email protected]> * removing Signed-off-by: Alex Cui <[email protected]> * adresing comment Signed-off-by: Alex Cui <[email protected]> * removing unused import Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addressing comment; Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * date for ja Signed-off-by: Alex Cui <[email protected]> * addresing comment Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * jenkins Signed-off-by: Alex Cui <[email protected]> * addresing comment Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * typo Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * adressing comment Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ci Signed-off-by: Alex Cui <[email protected]> --------- Signed-off-by: Alex Cui <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
* Fix space issue with ZH ITN Signed-off-by: Anand Joseph <[email protected]> * Update Jenkinsfile Update FST paths Signed-off-by: anand-nv <[email protected]> --------- Signed-off-by: Anand Joseph <[email protected]> Signed-off-by: anand-nv <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Anand Joseph <[email protected]> Co-authored-by: anand-nv <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Fixes issue with sparrowhawk builds as the original base image is no longer maintained and build breaks Signed-off-by: anand-nv <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
into hi_tn Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
mgrafu
reviewed
Jan 22, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
mgrafu
reviewed
Jan 22, 2025
nemo_text_processing/text_normalization/hi/data/money/major_minor_currencies.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This pull request introduces enhanced functionality for three classes: Measure, Money, and Date. These improvements are designed to increase usability and flexibility in handling various scenarios related to measurement units, currency transactions, and date manipulations.
Key Changes:
Measure Class:
Money Class:
Date Class:
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.