Skip to content

Comma bugfix for En electronics #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgrafu merged 3 commits into from
Sep 25, 2025
Merged

Comma bugfix for En electronics #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdfcc4a
fix bug with commas and electronics
mgrafu Sep 10, 2025
ffcb7ef
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 10, 2025
775de72
update jenkins
mgrafu Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pipeline {

AR_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/04-24-24-0'
DE_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/10-23-24-0'
EN_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/09-04-24-0'
EN_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/09-25-25-0'
ES_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/09-25-24-0'
ES_EN_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/08-30-24-0'
FR_TN_CACHE='/home/jenkins/TestData/text_norm/ci/grammars/04-07-25-0'
Expand Down
7 changes: 4 additions & 3 deletions nemo_text_processing/text_normalization/en/taggers/electronic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,15 @@ def __init__(self, cardinal: GraphFst, deterministic: bool = True):

full_stop_accep = pynini.accep(".")
dollar_accep = pynini.accep("$") # Include for the correct transduction of the money graph
excluded_symbols = full_stop_accep | dollar_accep
excluded_symbols = full_stop_accep | dollar_accep | pynini.accep(",")
filtered_symbols = pynini.difference(accepted_symbols, excluded_symbols)
accepted_characters = NEMO_ALPHA | NEMO_DIGIT | filtered_symbols
domain_component = full_stop_accep + pynini.closure(accepted_characters, 2)
graph_domain = (
graph_domain = pynutil.add_weight(
pynutil.insert('domain: "')
+ (pynini.closure(accepted_characters, 1) + pynini.closure(domain_component, 1))
+ pynutil.insert('"')
+ pynutil.insert('"'),
0.1,
).optimize()

graph |= pynutil.add_weight(graph_domain, MIN_NEG_WEIGHT)
Expand Down
3 changes: 2 additions & 1 deletion tests/nemo_text_processing/en/data_text_normalization/test_cases_electronic.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@ https://www.nvidia.com/dgx-basepod/~HTTPS colon slash slash WWW dot NVIDIA dot c
i can use your card ending in 8876~i can use your card ending in eight eight seven six
upgrade/update~upgrade slash update
upgrade / update~upgrade slash update
upgrade/update/downgrade~upgrade slash update slash downgrade
upgrade/update/downgrade~upgrade slash update slash downgrade
5.4, or 5.5~five point four, or five point five
Loading