Skip to content

Dont include imagePullSecret with empty name in service chart. #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecolternv merged 3 commits into from
Jan 5, 2026
Merged

Dont include imagePullSecret with empty name in service chart. #199

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed3ccd3
Dont include imagePullSecret if there is no imagePullSecret set
ecolternv Dec 30, 2025
b84cea7
Update router and web-ui as well
ecolternv Dec 30, 2025
0198005
Keep at version 1.0.1 for all charts
ecolternv Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions deployments/charts/quick-start/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ dependencies:
version: 4.13.2
repository: https://kubernetes.github.io/ingress-nginx
- name: service
version: 1.0.1
version: 1.0.2
repository: file://../service
- name: web-ui
version: 1.0.1
version: 1.0.2
repository: file://../web-ui
- name: router
version: 1.0.0
version: 1.0.1
repository: file://../router
- name: backend-operator
version: 1.0.1
Expand Down
2 changes: 1 addition & 1 deletion deployments/charts/router/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.0
version: 1.0.1


# This is the version number of the application being deployed. This version number should be
Expand Down
2 changes: 2 additions & 0 deletions deployments/charts/router/templates/router-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.global.imagePullSecret }}
imagePullSecrets:
- name: {{ .Values.global.imagePullSecret }}
{{- end }}
serviceAccountName: {{ .Values.services.service.serviceAccountName | default "default" }}
{{- with .Values.services.service.initContainers }}
initContainers:
Expand Down
2 changes: 1 addition & 1 deletion deployments/charts/service/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.1
version: 1.0.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 2 additions & 0 deletions deployments/charts/service/templates/agent-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ spec:
{{- end}}
tolerations:
{{ toYaml .Values.services.agent.tolerations | nindent 8 }}
{{- if .Values.global.imagePullSecret }}
imagePullSecrets:
- name: {{ .Values.global.imagePullSecret }}
{{- end }}
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.agent.serviceAccountName "Values" .Values) }}
{{- with .Values.services.agent.initContainers }}
initContainers:
Expand Down
2 changes: 2 additions & 0 deletions deployments/charts/service/templates/api-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,10 @@ spec:
{{- end}}
tolerations:
{{ toYaml .Values.services.service.tolerations | nindent 8 }}
{{- if .Values.global.imagePullSecret }}
imagePullSecrets:
- name: {{ .Values.global.imagePullSecret }}
{{- end }}
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.service.serviceAccountName "Values" .Values) }}
{{- with .Values.services.service.initContainers }}
initContainers:
Expand Down
2 changes: 2 additions & 0 deletions deployments/charts/service/templates/delayed-job-monitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ spec:
{{- end}}
tolerations:
{{ toYaml .Values.services.delayedJobMonitor.tolerations | nindent 8 }}
{{- if .Values.global.imagePullSecret }}
imagePullSecrets:
- name: {{ .Values.global.imagePullSecret }}
{{- end }}
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.delayedJobMonitor.serviceAccountName "Values" .Values) }}
{{- with .Values.services.delayedJobMonitor.initContainers }}
initContainers:
Expand Down
2 changes: 2 additions & 0 deletions deployments/charts/service/templates/logger-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ spec:
{{- end}}
tolerations:
{{ toYaml .Values.services.logger.tolerations | nindent 8 }}
{{- if .Values.global.imagePullSecret }}
imagePullSecrets:
- name: {{ .Values.global.imagePullSecret }}
{{- end }}
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.logger.serviceAccountName "Values" .Values) }}
{{- with .Values.services.logger.initContainers }}
initContainers:
Expand Down
2 changes: 2 additions & 0 deletions deployments/charts/service/templates/worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ spec:
{{- end}}
tolerations:
{{ toYaml .Values.services.worker.tolerations | nindent 8 }}
{{- if .Values.global.imagePullSecret }}
imagePullSecrets:
- name: {{ .Values.global.imagePullSecret }}
{{- end }}
serviceAccountName: {{ include "osmo.service-account-name" (dict "serviceAccountName" .Values.services.worker.serviceAccountName "Values" .Values) }}
{{- with .Values.services.worker.initContainers }}
initContainers:
Expand Down
2 changes: 1 addition & 1 deletion deployments/charts/web-ui/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.1
version: 1.0.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 2 additions & 0 deletions deployments/charts/web-ui/templates/ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,10 @@ spec:
{{- end}}
tolerations:
{{ toYaml .Values.services.ui.tolerations | nindent 8 }}
{{- if .Values.global.imagePullSecret }}
imagePullSecrets:
- name: {{ .Values.global.imagePullSecret }}
{{- end }}
{{- if .Values.services.ui.initContainers }}
initContainers:
{{- toYaml .Values.services.ui.initContainers | nindent 6 }}
Expand Down