[TRTLLM-10312][perf] Improve performance of _write_finish_reasons in TorchSampler #10459
+91
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #30754 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #30754 [ run ] completed with state
|
zhenhuaw-me
added
the
Decoding/Sampling
stnie
force-pushed
the
develop/sampler/write_finish_reasons_perf
branch
from
060564a to
1f9cd59
Compare
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #30888 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #30888 [ run ] completed with state
|
stnie
force-pushed
the
develop/sampler/write_finish_reasons_perf
branch
from
89264aa to
16bdf59
Compare
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #31071 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #31071 [ run ] completed with state |
- Added `max_lengths_tensor` to the `Store` class to cache max_length per request. - Introduced `_is_new_request` method to streamline request state checks. - Updated `setup_sampler_step` to fill `max_lengths_tensor` based on request parameters. - Refactored `_are_max_length` for improved token processing on device. Signed-off-by: Stefan Niebler <[email protected]>
- Introduced `end_ids` tensor in the `Store` class to store end IDs for each request. - Updated `setup_sampler_step` to fill `end_ids` based on request parameters. - Refactored `_are_end_id` method to utilize the new `end_ids` tensor for better performance. Signed-off-by: Stefan Niebler <[email protected]>
…usted override of setup_sampler_step Signed-off-by: Stefan Niebler <[email protected]>
…_tensor Signed-off-by: Stefan Niebler <[email protected]>
stnie
force-pushed
the
develop/sampler/write_finish_reasons_perf
branch
from
16bdf59 to
570094a
Compare
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #31228 [ run ] triggered by Bot. Commit: |
stnie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Adjust
_are_end_idand_are_max_lengthfunction in_write_finish_reasonsto omit host to device communication, by storing theend_idsandmax_lengthsinformation of each request in a device buffer. This information is only stored once per request as it is constant over time and therefore does not need to be gathered from the request every iteration.This change is intended to improve overall performance of
_write_finish_reasonsandsample_asyncPerformance Results (Preliminary)
ToT:
Request / second (TinyLlama-1.1B, ISL 1024, OSL 2048, BatchSize 512)
This PR:
Test Coverage
The general functionality did not change, therefore the following tests continue to cover the functionality.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.