Skip to content

Conversation

@lucaslie
Copy link
Member

@lucaslie lucaslie commented Jan 6, 2026

Summary by CodeRabbit

  • Tests
    • Removed waiver entries for three previously skipped integration tests. These tests are now included in the active test suite.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

NOTE: wait for #10466 and https://gitlab-master.nvidia.com/ftp/llm-models/-/merge_requests/450 to merge

No failure is fixed here. Just making sure we add the right model to llm-models

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lucaslie lucaslie requested a review from EmmaQiaoCh January 6, 2026 21:33
@lucaslie lucaslie self-assigned this Jan 6, 2026
@lucaslie lucaslie moved this from Backlog to In progress in AutoDeploy Board Jan 6, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

Three test waiver entries are removed from the integration test waiver list. Previously skipped tests for Llama-4 Scout model builds and VLM patch validation in single GPU deployment scenarios will now execute in the integration test suite.

Changes

Cohort / File(s) Summary
Test Waivers
tests/integration/test_lists/waives.txt
Removed three SKIP entries: two for test_ad_build_small_single.py::test_build_ad with Llama-4-Scout-17B variants and one for test_llama4_vlm_patch.py::test_build_run_llama4_vlm. Tests will no longer be waived during integration test runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks substantive content. While it follows the template structure, the key sections (Description and Test Coverage) are empty or minimal. Only a dependency note is provided without explanation of the changes being made. Add a clear explanation of why these waiver entries are being removed and what test coverage validates these changes. Document the dependency on PR #10466 and the external MR more explicitly.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing waiver/skip entries for LLaMA 4 scout tests. It directly reflects the functional changes documented in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00355b2 and 6408151.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation bot moved this from In progress to In review in AutoDeploy Board Jan 6, 2026
Signed-off-by: Lucas Liebenwein <[email protected]>
@lucaslie lucaslie requested a review from a team as a code owner January 7, 2026 20:38
@lucaslie lucaslie requested a review from taylor-yb-lee January 7, 2026 20:38
@lucaslie
Copy link
Member Author

lucaslie commented Jan 7, 2026

/bot run

@lucaslie lucaslie removed the request for review from taylor-yb-lee January 7, 2026 20:38
@lucaslie lucaslie enabled auto-merge (squash) January 7, 2026 20:39
@tensorrt-cicd
Copy link
Collaborator

PR_Github #30929 [ run ] triggered by Bot. Commit: 321a714

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30929 [ run ] completed with state SUCCESS. Commit: 321a714
/LLM/main/L0_MergeRequest_PR pipeline #23891 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@lucaslie
Copy link
Member Author

lucaslie commented Jan 8, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30948 [ run ] triggered by Bot. Commit: 321a714

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30948 [ run ] completed with state SUCCESS. Commit: 321a714
/LLM/main/L0_MergeRequest_PR pipeline #23909 completed with status: 'SUCCESS'

@lucaslie lucaslie merged commit 30f8455 into NVIDIA:main Jan 8, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants