Skip to content

Conversation

@anish-shanbhag
Copy link
Collaborator

@anish-shanbhag anish-shanbhag commented Jan 7, 2026

Description

Currently, users need to clone Triton and build it from source in order to use the Triton MoE kernels. This change adds triton-kernels as a dependency to eliminate this extra step.

Test Coverage

This functionality is covered by the config database tests added in #9382, which include H200 tests that use the Triton MoE backend (e.g. https://github.com/NVIDIA/TensorRT-LLM/blob/main/tests/scripts/perf-sanity/config_database_h200_sxm.yaml#L192)

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • New Features

    • Triton kernels support is now integrated as a required component for MoE and related operations.
  • Documentation

    • Simplified Triton MoE backend setup instructions with minimal YAML-based configuration.
  • Chores

    • Added triton-kernels as an explicit dependency; consolidated Triton-related imports; updated tests to reflect required kernel availability.

✏️ Tip: You can customize this high-level summary in your review settings.

@anish-shanbhag anish-shanbhag marked this pull request as ready for review January 7, 2026 04:21
@anish-shanbhag anish-shanbhag requested review from a team as code owners January 7, 2026 04:21
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

The changes make Triton kernels a required dependency by adding triton-kernels to requirements.txt, converting conditional imports and runtime availability checks to unconditional top-level imports across multiple production modules, removing test skips tied to kernel availability, and updating documentation to reflect the simplified Triton MoE backend setup.

Changes

Cohort / File(s) Summary
Attribution & Documentation
ATTRIBUTIONS-Python.md, examples/models/core/gpt_oss/README.md
Added new attribution block for triton-kernels (v1.0.0); simplified Triton MoE backend setup instructions from multi-step build guidance to concise configuration snippet.
Dependencies
requirements.txt
Added triton-kernels package sourced from Triton Git repository (v3.5.0 subdirectory path) as required dependency alongside existing triton==3.5.0 entry.
Fused MOE Production Code
tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py, tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
Replaced guarded import blocks with unconditional top-level Triton imports; removed IS_TRITON_KERNELS_AVAILABLE flag checks and fallback handling; simplified gating logic to remove kernel availability verification.
Core Module Implementations
tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py, tensorrt_llm/_torch/modules/triton_linear.py
Removed dynamic Triton kernel discovery, version assertions, and import-availability checks; converted all Triton-related imports to unconditional top-level imports; eliminated ImportError raises in constructors that gated on kernel availability.
Test Suites
tests/integration/defs/accuracy/test_llm_api_pytorch.py, tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py, tests/unittest/_torch/modeling/test_modeling_gpt_oss.py, tests/unittest/_torch/modules/test_fused_moe.py, tests/unittest/_torch/modules/test_triton_linear.py
Removed imports of IS_TRITON_KERNELS_AVAILABLE and all conditional skip decorators/blocks; tests now execute unconditionally regardless of Triton kernel availability state.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description adequately explains the issue, solution, and test coverage, though it references external test files rather than providing detailed inline test examples.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately summarizes the primary change—adding triton-kernels as a packaged dependency—which is the core objective reflected across all modified files.

✏️ Tip: You can configure your own custom Pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @ATTRIBUTIONS-Python.md:
- Line 62426: The opening fenced code block currently lacks a language
specifier; edit the fence that begins the copyright snippet (the triple
backticks) and change it from ``` to ```text so the block reads as a text code
fence (ensure only the opening fence is updated and leave the enclosed copyright
lines unchanged).
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb2f883 and 3ffdba4.

📒 Files selected for processing (12)
  • ATTRIBUTIONS-Python.md
  • examples/models/core/gpt_oss/README.md
  • requirements.txt
  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
  • tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
  • tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
  • tensorrt_llm/_torch/modules/triton_linear.py
  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
  • tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py
  • tests/unittest/_torch/modeling/test_modeling_gpt_oss.py
  • tests/unittest/_torch/modules/test_fused_moe.py
  • tests/unittest/_torch/modules/test_triton_linear.py
💤 Files with no reviewable changes (5)
  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
  • tests/unittest/_torch/modeling/test_modeling_gpt_oss.py
  • tests/unittest/_torch/modules/test_fused_moe.py
  • tests/unittest/_torch/auto_deploy/unit/multigpu/custom_ops/test_mxfp4_moe_ep.py
  • tests/unittest/_torch/modules/test_triton_linear.py
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{md,rst}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

When documenting CLI commands for TensorRT-LLM tools like trtllm-serve, trtllm-bench, or trtllm-eval, prefer using --config over --extra_llm_api_options for specifying configuration files

Files:

  • ATTRIBUTIONS-Python.md
  • examples/models/core/gpt_oss/README.md
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: The code developed for TensorRT-LLM should conform to Python 3.8+
Indent Python code with 4 spaces. Do not use tabs
Always maintain the namespace when importing Python modules, even if only one class or function from a module is used
Python filenames should use snake_case (e.g., some_file.py)
Python classes should use PascalCase (e.g., class SomeClass)
Python functions and methods should use snake_case (e.g., def my_awesome_function():)
Python local variables should use snake_case, with prefix k for variable names that start with a number (e.g., k_99th_percentile)
Python global variables should use upper snake_case with prefix G (e.g., G_MY_GLOBAL)
Python constants should use upper snake_case (e.g., MY_CONSTANT)
Avoid shadowing variables declared in an outer scope in Python
Initialize all externally visible members of a Python class in the constructor
For Python interfaces that may be used outside a file, prefer docstrings over comments
Use comments in Python for code within a function, or interfaces that are local to a file
Use Google-style docstrings for Python classes and functions, which can be parsed by Sphinx
Python attributes and variables can be documented inline with the format """<type>: Description"""
Avoid using reflection in Python when functionality can be easily achieved without reflection
When using try-except blocks in Python, limit the except clause to the smallest set of errors possible
When using try-except blocks in Python to handle multiple possible variable types (duck-typing), keep the body of the try as small as possible and use the else block for the main logic

Files:

  • tensorrt_llm/_torch/modules/triton_linear.py
  • tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
  • tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
**/*.{cpp,cc,cxx,h,hpp,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification

Files:

  • tensorrt_llm/_torch/modules/triton_linear.py
  • tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
  • tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
🧠 Learnings (12)
📚 Learning: 2025-08-27T17:50:13.264Z
Learnt from: venkywonka
Repo: NVIDIA/TensorRT-LLM PR: 6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.

Applied to files:

  • examples/models/core/gpt_oss/README.md
📚 Learning: 2025-08-14T23:23:27.449Z
Learnt from: djns99
Repo: NVIDIA/TensorRT-LLM PR: 6915
File: cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu:4010-4012
Timestamp: 2025-08-14T23:23:27.449Z
Learning: For MOE (Mixture of Experts) code reviews in TensorRT-LLM, avoid repeatedly suggesting finalize fusion validation checks and safety assertions. The user djns99 has indicated these suggestions are repetitive and unwanted across multiple MOE-related changes.

Applied to files:

  • examples/models/core/gpt_oss/README.md
  • tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
  • tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
📚 Learning: 2025-08-20T07:43:36.447Z
Learnt from: ChristinaZ
Repo: NVIDIA/TensorRT-LLM PR: 7068
File: cpp/tensorrt_llm/kernels/moeTopKFuncs.cuh:169-172
Timestamp: 2025-08-20T07:43:36.447Z
Learning: In TensorRT-LLM MOE kernels, when processing up to 128 experts across 32 threads, each thread handles at most 4 experts (N < 5 constraint), where N represents candidates per thread rather than total system capacity.

Applied to files:

  • examples/models/core/gpt_oss/README.md
📚 Learning: 2025-08-21T02:39:12.009Z
Learnt from: djns99
Repo: NVIDIA/TensorRT-LLM PR: 7104
File: cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu:1475-1480
Timestamp: 2025-08-21T02:39:12.009Z
Learning: The min latency mode functionality in TensorRT-LLM MOE kernels (cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu) is deprecated and no longer being maintained/updated, as confirmed by djns99. Bug reports and optimization suggestions for the computeStridesTmaWarpSpecializedLowLatencyKernel and related min latency code paths should be deprioritized.

Applied to files:

  • examples/models/core/gpt_oss/README.md
  • tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
  • tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
📚 Learning: 2025-10-20T17:09:21.560Z
Learnt from: nvchenghaoz
Repo: NVIDIA/TensorRT-LLM PR: 8469
File: tensorrt_llm/_torch/auto_deploy/transform/library/rms_norm.py:180-182
Timestamp: 2025-10-20T17:09:21.560Z
Learning: In tensorrt_llm/_torch/auto_deploy/transform/library/rms_norm.py, the _gated_rmsnorm_replacement function does not need to cast the output of torch.ops.auto_deploy.torch_rmsnorm_gated back to the input dtype, even though the custom op returns fp32. The dtype handling is managed elsewhere or the fp32 output is acceptable for downstream consumers.

Applied to files:

  • tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
📚 Learning: 2025-08-19T12:45:11.997Z
Learnt from: amitz-nv
Repo: NVIDIA/TensorRT-LLM PR: 7033
File: tensorrt_llm/_torch/pyexecutor/model_engine.py:0-0
Timestamp: 2025-08-19T12:45:11.997Z
Learning: In tensorrt_llm/_torch/pyexecutor/model_engine.py, DoRA (Delta Orthogonal Rank Adaptation) functionality was removed from the PyTorch flow to eliminate issues with inverted DoRA detection logic. The original is_dora condition was checking if scaling_vec_pointer == 0, which was potentially incorrect.

Applied to files:

  • tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
  • tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
📚 Learning: 2025-12-19T06:31:54.973Z
Learnt from: nvyocox
Repo: NVIDIA/TensorRT-LLM PR: 10117
File: tensorrt_llm/_torch/auto_deploy/transform/library/fuse_rope_attention.py:336-339
Timestamp: 2025-12-19T06:31:54.973Z
Learning: In tensorrt_llm/_torch/auto_deploy/transform/library/fuse_rope_attention.py, the cast to torch.float16 for qkv_node before creating the AttentionPlugin is intentional and required because DriveOS LLM expects float16 dtype specifically. This should not be changed to preserve original dtype or made configurable for bfloat16 models in the DriveOS LLM ONNX export path.

Applied to files:

  • tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py
📚 Learning: 2025-08-19T12:45:35.429Z
Learnt from: amitz-nv
Repo: NVIDIA/TensorRT-LLM PR: 7033
File: tensorrt_llm/_torch/pyexecutor/model_engine.py:2086-2092
Timestamp: 2025-08-19T12:45:35.429Z
Learning: DoRA (Delta Orthogonal Rank Adaptation) functionality has been removed from the PyTorch flow in tensorrt_llm/_torch/pyexecutor/model_engine.py. The is_dora field is computed but not used downstream in the PyTorch flow, so converting it to a tensor would be wasteful overhead.

Applied to files:

  • tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
📚 Learning: 2025-08-08T22:03:40.707Z
Learnt from: sklevtsov-nvidia
Repo: NVIDIA/TensorRT-LLM PR: 3294
File: cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu:1198-1209
Timestamp: 2025-08-08T22:03:40.707Z
Learning: In the CUTLASS MoE kernels (cpp/tensorrt_llm/cutlass_extensions), when `layout_info.fusion` is set to `TmaWarpSpecializedGroupedGemmInput::EpilogueFusion::FINALIZE`, the `router_scales` parameter must be non-null by design. The fused finalize kernel epilogue does not perform nullptr checks and requires valid router scales to function correctly. This is an implicit contract that callers must satisfy when enabling the FINALIZE fusion mode.

Applied to files:

  • tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py
  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
📚 Learning: 2025-10-20T16:54:09.824Z
Learnt from: nvchenghaoz
Repo: NVIDIA/TensorRT-LLM PR: 8469
File: tensorrt_llm/_torch/auto_deploy/custom_ops/rms_norm.py:6-6
Timestamp: 2025-10-20T16:54:09.824Z
Learning: In tensorrt_llm/_torch/auto_deploy/custom_ops/rms_norm.py, the import `from ...modules.mamba.layernorm_gated import _layer_norm_fwd` is correct and should not be changed to modules.fla.layernorm_gated. The _layer_norm_fwd function exists in both modules/mamba/layernorm_gated.py and modules/fla/layernorm_gated.py, but the mamba version is the intended implementation for this use case.

Applied to files:

  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
📚 Learning: 2025-11-14T11:22:03.729Z
Learnt from: nzmora-nvidia
Repo: NVIDIA/TensorRT-LLM PR: 9163
File: tensorrt_llm/_torch/auto_deploy/custom_ops/quant.py:107-113
Timestamp: 2025-11-14T11:22:03.729Z
Learning: In TensorRT-LLM AutoDeploy custom ops, when adding hardware capability checks to select between kernel implementations (e.g., cuBLAS vs. CUDA kernel), use descriptive variable names that identify the specific GPU architectures or families being targeted (e.g., `is_blackwell_geforce_or_ada`) rather than generic names like `enable_cuda_core`. This makes it clear that the code is selecting an implementation path based on hardware capabilities, not enabling/disabling hardware features.

Applied to files:

  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
📚 Learning: 2025-08-19T03:35:20.866Z
Learnt from: djns99
Repo: NVIDIA/TensorRT-LLM PR: 6915
File: cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu:4616-4626
Timestamp: 2025-08-19T03:35:20.866Z
Learning: In the MOE profiler TMA workspace preparation (cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu), the overlapping of TMA WS regions for NONE and FINALIZE variants is deliberate design to save memory space, as confirmed by djns99. The comment "reuse the same pointers to save space" reflects this intentional behavior.

Applied to files:

  • tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py
🧬 Code graph analysis (4)
tensorrt_llm/_torch/modules/triton_linear.py (1)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py (1)
  • maybe_update_stride (176-179)
tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py (3)
tensorrt_llm/_torch/auto_deploy/custom_ops/attention_interface.py (1)
  • get (1247-1249)
tensorrt_llm/_torch/auto_deploy/transform/interface.py (1)
  • get (539-541)
tensorrt_llm/_torch/auto_deploy/models/quant_config_reader.py (1)
  • get (74-77)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py (1)
tensorrt_llm/_torch/models/modeling_gpt_oss.py (1)
  • swiglu (204-212)
tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py (1)
tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py (1)
  • TritonEPRouter (111-173)
🪛 markdownlint-cli2 (0.18.1)
ATTRIBUTIONS-Python.md

62425-62425: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


62426-62426: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


62451-62451: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


62451-62451: Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (7)
tensorrt_llm/_torch/auto_deploy/transform/library/mxfp4_moe.py (1)

222-222: LGTM! Simplifies gating logic by removing Triton kernel availability check.

The transform now proceeds whenever the quantization method is "mxfp4", without requiring a runtime check for Triton kernel availability. This aligns with the PR's goal of making triton-kernels a required dependency.

tensorrt_llm/_torch/modules/triton_linear.py (2)

7-8: LGTM! Unconditional imports reflect triton-kernels as required dependency.

The Triton kernel imports are now unconditional, consistent with triton-kernels being a packaged dependency rather than an optional component.


14-14: LGTM! Consolidates Triton-related imports.

The import of maybe_update_stride is now part of the unconditional top-level imports, simplifying the module structure.

tensorrt_llm/_torch/modules/fused_moe/fused_moe_triton.py (1)

10-16: LGTM! Comprehensive move to unconditional Triton imports.

All Triton kernel imports (swiglu, matmul_ogs, routing, numerics, tensor utilities) are now unconditionally imported at the top level. This reflects the architectural change to make triton-kernels a required dependency.

tensorrt_llm/_torch/auto_deploy/custom_ops/fused_moe/mxfp4_moe.py (1)

7-15: LGTM! Triton imports now unconditional across custom ops.

All Triton kernel imports and the TritonEPRouter are now imported unconditionally, enabling the MXFP4 MoE custom ops to always use Triton-based implementations.

requirements.txt (1)

69-71: The triton-kernels git dependency is correctly configured.

The tag v3.5.0 exists in the triton repository and the python/triton_kernels subdirectory is present at that tag, making the git+https installation method valid.

examples/models/core/gpt_oss/README.md (1)

111-118: Documentation update aligns with simplified Triton MoE setup and follows guidelines.

The changes correctly simplify the documentation to reflect Triton kernels as a packaged dependency, removing the need for complex manual setup. The use of --config flag in Line 113 follows the coding guidelines for TensorRT-LLM CLI tool documentation. The YAML configuration snippet is clear and concise.

License: `MIT License`

- `LICENSE` (from triton repository root):
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Specify language for fenced code block.

Line 62426 opens a code fence without a language identifier. Specify text as the language to resolve the markdown linting warning.

🔎 Proposed fix
-```
+```text
 Copyright 2018-2020 Philippe Tillet
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
```
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

62426-62426: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents
In @ATTRIBUTIONS-Python.md at line 62426, The opening fenced code block
currently lacks a language specifier; edit the fence that begins the copyright
snippet (the triple backticks) and change it from ``` to ```text so the block
reads as a text code fence (ensure only the opening fence is updated and leave
the enclosed copyright lines unchanged).

@anish-shanbhag
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30832 [ run ] triggered by Bot. Commit: 3ffdba4

@anish-shanbhag anish-shanbhag changed the title [None][feat] Include triton-kernels as a packaged dependency [https://nvbugs/5761391][fix] Include triton-kernels as a packaged dependency Jan 7, 2026
@tensorrt-cicd
Copy link
Collaborator

PR_Github #30832 [ run ] completed with state SUCCESS. Commit: 3ffdba4
/LLM/main/L0_MergeRequest_PR pipeline #23812 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@anish-shanbhag anish-shanbhag force-pushed the ashanbhag/triton-dependency branch from 3ffdba4 to 406f21c Compare January 7, 2026 17:42
@anish-shanbhag
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30938 [ run ] triggered by Bot. Commit: 754e5ea

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30938 [ run ] completed with state SUCCESS. Commit: 754e5ea
/LLM/main/L0_MergeRequest_PR pipeline #23900 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants