Skip to content

Conversation

@Linda-Stadter
Copy link
Collaborator

@Linda-Stadter Linda-Stadter commented Jan 7, 2026

Description

Fix for bug https://nvbugspro.nvidia.com/bug/5628848

We are using nanobind recursive stub generation since this PR.
There has been a fix for recursive stub generation in nanobind version 2.9.0. This PR makes sure nanobind is updated to that version.

Test Coverage

Tested stubs in IDE.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Linda-Stadter
Copy link
Collaborator Author

/bot run

@Linda-Stadter Linda-Stadter changed the title [https:://nvbugs/5628848][fix] Fix nanobind stub generation [https://nvbugs/5628848][fix] Fix nanobind stub generation Jan 7, 2026
@Linda-Stadter Linda-Stadter changed the title [https://nvbugs/5628848][fix] Fix nanobind stub generation [https://nvbugs/5628848][fix] Fix nanobind stub generation Jan 7, 2026
@tensorrt-cicd
Copy link
Collaborator

PR_Github #30923 [ run ] triggered by Bot. Commit: 6e5e550

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30923 [ run ] completed with state SUCCESS. Commit: 6e5e550
/LLM/main/L0_MergeRequest_PR pipeline #23885 completed with status: 'SUCCESS'

@Linda-Stadter
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31051 [ run ] triggered by Bot. Commit: f0589db

@Linda-Stadter Linda-Stadter marked this pull request as ready for review January 8, 2026 10:29
@Linda-Stadter Linda-Stadter requested a review from a team as a code owner January 8, 2026 10:29
@Linda-Stadter Linda-Stadter self-assigned this Jan 8, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

The PR modifies nanobind stub generation to output to a "bindings" directory instead of the current directory, with post-processing to rename the generated stub file to __init__.pyi. The bindings.pyi entry is removed from the package data configuration in setup.py.

Changes

Cohort / File(s) Summary
Build and Packaging Configuration
scripts/build_wheel.py, setup.py
Updated nanobind stub generation output path from "." to "bindings" directory with post-generation rename of bindings/bindings.pyi to bindings/__init__.pyi; removed bindings.pyi from package_data list in setup.py

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format [NVBugs ID][type] and accurately summarizes the main change: fixing nanobind stub generation.
Description check ✅ Passed The PR description includes a clear explanation of the bug fix, references the NVBugs ticket and related PR, and explains the nanobind version update and stub generation changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31051 [ run ] completed with state SUCCESS. Commit: f0589db
/LLM/main/L0_MergeRequest_PR pipeline #23991 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: Linda-Stadter <[email protected]>
@Linda-Stadter
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31103 [ run ] triggered by Bot. Commit: 26d2e16

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31103 [ run ] completed with state SUCCESS. Commit: 26d2e16
/LLM/main/L0_MergeRequest_PR pipeline #24020 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@Linda-Stadter
Copy link
Collaborator Author

/bot run

@Linda-Stadter Linda-Stadter requested a review from ixlmar January 9, 2026 09:51
Copy link
Collaborator

@ixlmar ixlmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31241 [ run ] triggered by Bot. Commit: 631850e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31242 [ run ] triggered by Bot. Commit: 631850e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31241 [ run ] completed with state ABORTED. Commit: 631850e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31242 [ run ] completed with state SUCCESS. Commit: 631850e
/LLM/main/L0_MergeRequest_PR pipeline #24144 completed with status: 'SUCCESS'

@schetlur-nv schetlur-nv merged commit 82dfef2 into NVIDIA:main Jan 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants