Skip to content

Conversation

@yihwang-nv
Copy link
Collaborator

@yihwang-nv yihwang-nv commented Jan 22, 2026

Description

This PR unwaive test:

unittest/_torch/attention/test_trtllm_flashinfer_symbol_collision.py::test_flashinfer_fused_moe_matches_torch_moe

Summary by CodeRabbit

  • Tests
    • Enabled a previously skipped test to run in the test suite, allowing for expanded test coverage.

✏️ Tip: You can customize this high-level summary in your review settings.

@yihwang-nv yihwang-nv requested a review from EmmaQiaoCh January 22, 2026 16:17
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

📝 Walkthrough

Walkthrough

A single SKIP entry is removed from the test waives configuration, enabling the previously skipped test test_flashinfer_fused_moe_matches_torch_moe to run in the test suite.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Removed SKIP directive for unittest/_torch/attention/test_trtllm_flashinfer_symbol_collision.py::test_flashinfer_fused_moe_matches_torch_moe, making this test eligible for execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete; it lacks motivation context, test coverage details, and PR checklist items required by the template. Add explanation for why the test was waived previously and why it can now run, confirm test coverage, and review the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: removing a SKIP waiver from a specific test to enable it to run.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…_collision.py::test_flashinfer_fused_moe_matches_torch_moe

Signed-off-by: Yihan Wang <yihwang@nvidia.com>
@yihwang-nv yihwang-nv force-pushed the yihwang/unwaive_symbol_collision branch from b46174c to 4d11f80 Compare January 22, 2026 16:18
@yihwang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast

@yihwang-nv yihwang-nv changed the title [https://nvbugs/5814215][chore] Unwaive test_trtllm_flashinfer_symbol_collision.py::test_flashinfer_fused_moe_matches_torch_moe [https://nvbugs/5814215][fix] Unwaive test_trtllm_flashinfer_symbol_collision.py::test_flashinfer_fused_moe_matches_torch_moe Jan 22, 2026
@tensorrt-cicd
Copy link
Collaborator

PR_Github #33203 [ run ] triggered by Bot. Commit: 4d11f80

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33203 [ run ] completed with state SUCCESS. Commit: 4d11f80
/LLM/main/L0_MergeRequest_PR pipeline #25652 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yihwang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33257 [ run ] triggered by Bot. Commit: 4d11f80

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33257 [ run ] completed with state ABORTED. Commit: 4d11f80
LLM/main/L0_MergeRequest_PR #25690 (Blue Ocean) completed with status: ABORTED

@yihwang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33272 [ run ] triggered by Bot. Commit: 4d11f80

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33272 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 8 PM PST on 1/22.

@ZhanruiSunCh
Copy link
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33285 [ run ] triggered by Bot. Commit: 4d11f80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants