Skip to content

[None][docs] Add CUDA Graph + LoRA in Feature Combination Matrix#11187

Merged
Funatiq merged 11 commits intoNVIDIA:mainfrom
JyChang012:add_cudagraph_lora_feat_mat
Feb 5, 2026
Merged

[None][docs] Add CUDA Graph + LoRA in Feature Combination Matrix#11187
Funatiq merged 11 commits intoNVIDIA:mainfrom
JyChang012:add_cudagraph_lora_feat_mat

Conversation

@JyChang012
Copy link
Member

@JyChang012 JyChang012 commented Feb 2, 2026

Summary by CodeRabbit

Documentation

  • Updated the feature comparison matrix to reflect expanded LoRA support across multiple features.

Description

Add CUDA Graph + LoRA in Feature Combination Matrix for #8279

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Jiayu Chang <jiayuc@nvidia.com>
@JyChang012 JyChang012 requested a review from a team as a code owner February 2, 2026 10:19
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Updated the LoRA feature row in the feature comparison matrix documentation, changing several cell values from "No/Untested" to "Yes/Untested" to reflect broader feature support.

Changes

Cohort / File(s) Summary
Documentation Update
docs/source/features/feature-combination-matrix.md
Updated LoRA row in feature comparison matrix with revised support status across multiple features.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description lacks critical sections; missing detailed explanation, test coverage information, and proper PR title following template format. Add proper PR title [None][doc] or relevant ticket, expand Description section with specific changes, and document Test Coverage and which checklist items were verified.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The pull request title accurately describes the main changes: adding CUDA Graph and LoRA entries to the Feature Combination Matrix, which aligns with the documented changes to the feature matrix file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Funatiq
Copy link
Collaborator

Funatiq commented Feb 4, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34769 [ run ] triggered by Bot. Commit: b317bf8

@chzblych
Copy link
Collaborator

chzblych commented Feb 4, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34805 [ run ] triggered by Bot. Commit: 3501f87

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34805 [ run ] completed with state SUCCESS. Commit: 3501f87
/LLM/main/L0_MergeRequest_PR pipeline #26864 completed with status: 'SUCCESS'

@Funatiq Funatiq changed the title [None][Doc] Add CUDA Graph + LoRA in Feature Combination Matrix [None][docs] Add CUDA Graph + LoRA in Feature Combination Matrix Feb 5, 2026
@Funatiq
Copy link
Collaborator

Funatiq commented Feb 5, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34935 [ reuse-pipeline ] triggered by Bot. Commit: 9cf01e2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34935 [ reuse-pipeline ] completed with state SUCCESS. Commit: 9cf01e2
Reusing PR_Github #34805 for commit 9cf01e2

@Funatiq Funatiq merged commit e483c72 into NVIDIA:main Feb 5, 2026
6 of 7 checks passed
SchumiDing pushed a commit to SchumiDing/TensorRT-LLM that referenced this pull request Feb 6, 2026
inciaf pushed a commit to inciaf/trtllm-energy-monitoring that referenced this pull request Feb 18, 2026
…DIA#11187)

Signed-off-by: Jiayu Chang <jiayuc@nvidia.com>
Signed-off-by: Ahmet Inci <ainci@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants