[https://nvbugs/6007967][fix] fix disagg pp hang issue#12528
[https://nvbugs/6007967][fix] fix disagg pp hang issue#12528bo-nv wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Bo Deng <deemod@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis pull request adds conditional MPI send flushing logic to the sample state broadcasting loop in the PyExecutor, forcing an MPI progress-driving wait when the executed batch queue is empty. Additionally, three test waivers for disaggregated serving tests are removed from the waiver list. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #40286 [ run ] triggered by Bot. Commit: |
|
PR_Github #40286 [ run ] completed with state
|
|
/bot run |
|
PR_Github #40335 [ run ] triggered by Bot. Commit: |
|
PR_Github #40335 [ run ] completed with state
|
|
/bot run |
|
PR_Github #40365 [ run ] triggered by Bot. Commit: |
|
PR_Github #40365 [ run ] completed with state
|
|
/bot run |
|
PR_Github #40397 [ run ] triggered by Bot. Commit: |
|
PR_Github #40397 [ run ] completed with state
|
|
/bot run |
|
PR_Github #40427 [ run ] triggered by Bot. Commit: |
|
PR_Github #40427 [ run ] completed with state
|
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.