[None][doc] Add MoE developer guide for fused_moe module#12534
[None][doc] Add MoE developer guide for fused_moe module#12534xxi-nv wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Add MOE_DEVELOPER_GUIDE.md covering architecture, backends, quantization support matrix, communication, canonical examples, and anti-patterns. Add AGENTS.md pointer to guide AI agents to read the doc before modifying MoE code. Signed-off-by: xxi <xxi@nvidia.com>
📝 WalkthroughWalkthroughA new documentation file Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tensorrt_llm/_torch/modules/fused_moe/MOE_DEVELOPER_GUIDE.md`:
- Line 7: The three fenced code blocks in MOE_DEVELOPER_GUIDE.md that currently
start with plain ``` should be annotated with a language tag (e.g., ```text) to
satisfy markdownlint MD040; locate the blocks that contain the diagrams starting
with "Input Hidden States", "ConfigurableMoE", and "routing() → [EPLB]" and
replace their opening fences with ```text so each fenced block includes the
language identifier.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8fbe2798-4698-450e-91a2-31bc2e00dfe0
📒 Files selected for processing (2)
AGENTS.mdtensorrt_llm/_torch/modules/fused_moe/MOE_DEVELOPER_GUIDE.md
…GUIDE.md Add ```text language identifier to three diagram code blocks to satisfy markdownlint MD040. Signed-off-by: xxi <xxi@nvidia.com>
|
/bot run --disable-fail-fast |
|
PR_Github #40320 [ run ] triggered by Bot. Commit: |
|
PR_Github #40320 [ run ] completed with state
|
|
/bot run |
|
PR_Github #40492 [ run ] triggered by Bot. Commit: |
|
PR_Github #40492 [ run ] completed with state
|
Summary
MOE_DEVELOPER_GUIDE.mdinfused_moe/covering architecture, backends, quantization support matrix, communication, canonical examples, and anti-patternsAGENTS.mdKey Files table to guide AI agents to read the doc before modifying MoE codeTest plan
can_implementmethods in each backend🤖 Generated with Claude Code
Summary by CodeRabbit