[None][fix] Replace assertions with warnings for unsupported logits/logprobs in speculative sampler#12547
Open
yifjiang wants to merge 1 commit intoNVIDIA:mainfrom
Open
[None][fix] Replace assertions with warnings for unsupported logits/logprobs in speculative sampler#12547yifjiang wants to merge 1 commit intoNVIDIA:mainfrom
yifjiang wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…ogprobs in speculative sampler When return_context_logits, return_generation_logits, or return_log_probs is requested with speculative decoding, the server crashes with an AssertionError. Replace these assertions with warnings so the server stays alive and the request completes without the unsupported fields. Signed-off-by: yifjiang <19356972+yifjiang@users.noreply.github.com>
svc-trtllm-gh-bot
added
the
Community want to contribute
mikeiovine
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return_context_logits,return_generation_logits, orreturn_log_probsis requested with speculative decoding, the server crashes with anAssertionErrorinspec_sampler_base.py.logger.warning()so the server stays alive. The request completes normally — the unsupported fields are simply not populated.Test plan
logprobs=Trueto a model serving with speculative decoding (e.g. MTP) — verify server logs a warning instead of crashing🤖 Generated with Claude Code