[None][infra] Skip already-applied patches gracefully in 3rdparty FetchContent#12550
[None][infra] Skip already-applied patches gracefully in 3rdparty FetchContent#12550achartier wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
|
/bot run |
📝 WalkthroughWalkthroughThe patch-application logic in the CMake build system is refactored to detect if a patch is already applied before attempting to apply it. A dry-run reverse patch is performed first; if successful, the patch is skipped. Otherwise, the patch is applied normally. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #40377 [ run ] triggered by Bot. Commit: |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
|
PR_Github #40377 [ run ] completed with state
|
Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
|
/bot run |
|
PR_Github #40398 [ run ] triggered by Bot. Commit: |
|
PR_Github #40398 [ run ] completed with state |
Summary by CodeRabbit
Description
Skip already-applied patches gracefully in 3rdparty FetchContent
Original implementation from @yunruis
Test Coverage
N/A
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.