Skip to content

[https://nvbugs/5919796][test] AutoDeploy: unwaive Super V3 autodeploy failure#12556

Open
galagam wants to merge 1 commit intoNVIDIA:mainfrom
nv-auto-deploy:gagam/remove-waive-5919796
Open

[https://nvbugs/5919796][test] AutoDeploy: unwaive Super V3 autodeploy failure#12556
galagam wants to merge 1 commit intoNVIDIA:mainfrom
nv-auto-deploy:gagam/remove-waive-5919796

Conversation

@galagam
Copy link
Collaborator

@galagam galagam commented Mar 26, 2026

Summary by CodeRabbit

  • Tests
    • Removed a skip condition for an accuracy test case, allowing it to run again in the test suite.

Description

Unwaive test. Failure does not reproduce on ToT.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…y failure

Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
@galagam
Copy link
Collaborator Author

galagam commented Mar 26, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8f1d9024-4d5e-4224-b837-7884eff38fb1

📥 Commits

Reviewing files that changed from the base of the PR and between 9cc7584 and b010b42.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single test case entry is removed from the waive list file, eliminating a skip for accuracy/test_llm_api_autodeploy.py::TestNemotronSuperV3::test_accuracy[bf16-4-attn_dp_off-trtllm] that was previously skipped due to issue http://nvbugs/5919796.

Changes

Cohort / File(s) Summary
Test Waive List
tests/integration/test_lists/waives.txt
Removed one test skip entry for the Nemotron SuperV3 accuracy test in bf16 mode with attention DP disabled (associated with nvbugs/5919796).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing a waived test entry because the failure no longer reproduces on tip-of-tree.
Description check ✅ Passed The description is minimal but adequate, explaining the purpose (unwaive test, failure no longer reproduces). However, it lacks clarity on specific test details and context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #40436 [ run ] triggered by Bot. Commit: b010b42 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #40436 [ run ] completed with state SUCCESS. Commit: b010b42
/LLM/main/L0_MergeRequest_PR pipeline #31528 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam
Copy link
Collaborator Author

galagam commented Mar 26, 2026

/bot run

@galagam galagam requested review from EmmaQiaoCh, greg-kwasniewski1 and zhenhuaw-me and removed request for zhenhuaw-me March 26, 2026 12:00
@tensorrt-cicd
Copy link
Collaborator

PR_Github #40442 [ run ] triggered by Bot. Commit: b010b42 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #40442 [ run ] completed with state SUCCESS. Commit: b010b42
/LLM/main/L0_MergeRequest_PR pipeline #31533 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@galagam
Copy link
Collaborator Author

galagam commented Mar 26, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #40458 [ run ] triggered by Bot. Commit: b010b42 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #40458 [ run ] completed with state SUCCESS. Commit: b010b42
/LLM/main/L0_MergeRequest_PR pipeline #31547 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@galagam
Copy link
Collaborator Author

galagam commented Mar 26, 2026

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #40464 [ run ] triggered by Bot. Commit: b010b42 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #40464 [ run ] completed with state SUCCESS. Commit: b010b42
/LLM/main/L0_MergeRequest_PR pipeline #31553 completed with status: 'SUCCESS'

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants