Skip to content

[mock] Testing the auto-assign PR functionality #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
venkywonka wants to merge 51 commits into from
Closed

[mock] Testing the auto-assign PR functionality #5725

venkywonka wants to merge 51 commits into from

Conversation

@venkywonka
Copy link
Collaborator

@venkywonka venkywonka commented Jul 3, 2025

No description provided.

venkywonka added 30 commits June 30, 2025 10:47
@venkywonka
first commit
00b419e 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
add some more module-owners/modules
40a7385 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
bug fix
fa9face 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
use default permissions in action
4786bd9 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
use new REVIEW_ASSIGNING_TOKEN secret
6e84969 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
pull_request->pull_request_target to access secrets
8f61bb0 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
dry run changes
c32a374 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Enhance auto-reviewer assignment with duplicate prevention and better UX
405f0d3 
- Add logic to check existing reviewers before assignment
- Skip auto-assignment if reviewers already exist (unless --force-assign)
- Improve logging and error handling with status messages
- Add force-assign option for manual override
- Switch back to pull_request trigger for proper access
- Fix workflow parameter handling for force_assign option

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Switch to pull_request_target for secret access
64438f5 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Add explicit permissions for pull request writes and secret access
d1a39b0 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Switch from pull_request_target to pull_request trigger
decd175
@venkywonka
Add auto-assign feature in github actions for PRs
5c8b292 
- Add logic to check existing reviewers before assignment
- Skip auto-assignment if reviewers already exist (unless --force-assign)
- Improve logging and error handling with status messages
- Add force-assign option for manual override
- Switch back to pull_request trigger for proper access
- Fix workflow parameter handling for force_assign option

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
docs: add detailed auto-assign PR reviewer documentation
e11ccf9 
Add comprehensive documentation about the GitHub action for automatic
PR reviewer assignment, including its behavior with CODEOWNERS,
module-based assignment, and existing reviewer respect.

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
add comprehensive testing, change to pull_request_target
9be3f69 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
fix: Major module mapping overhaul for auto-assign reviewers
63339cd 
- Replace broad 'CI/CD' with 5 granular modules
- Separate test concerns from pipeline logic
- Move module-owners.json to .github/ for consistency

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
first commit
7829374 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
add some more module-owners/modules
7091eaf 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
bug fix
52713d2 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
use default permissions in action
8435ff0 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
use new REVIEW_ASSIGNING_TOKEN secret
e58fe23 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
pull_request->pull_request_target to access secrets
89322bf 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
dry run changes
9d78b23 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Enhance auto-reviewer assignment with duplicate prevention and better UX
831501f 
- Add logic to check existing reviewers before assignment
- Skip auto-assignment if reviewers already exist (unless --force-assign)
- Improve logging and error handling with status messages
- Add force-assign option for manual override
- Switch back to pull_request trigger for proper access
- Fix workflow parameter handling for force_assign option

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Switch to pull_request_target for secret access
d5cdb65 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Add explicit permissions for pull request writes and secret access
a2814d3 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Switch from pull_request_target to pull_request trigger
26e4546
@venkywonka
Merge fork-user/venky/auto-assign-pr-test into origin-user/venky/auto…
af43fd9 
…-assign-pr-test

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Fix CONTRIBUTING.md to match fork version completely
192a3be 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Complete merge with remote user/venky/auto-assign-pr-test changes
c448fba 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Enhanced assign_reviewers.py with detailed feedback for unmapped file…
18683e3 
…s and modules

- Modified map_modules() to return both modules and unmapped files
- Enhanced gather_reviewers() to track modules without owners
- Added comprehensive feedback when no reviewers are assigned:
  - Warns about files with no module mapping
  - Warns about modules with no owners
  - Explains specific reasons for no assignment
  - Provides actionable guidance for fixing coverage gaps
- Updated test cases to cover new functionality
- Added test cases for unmapped files and modules without owners

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Copy link
Collaborator Author

venkywonka commented Jul 8, 2025

Previous commit tests assignment, below is the auto-assignment log snippet proving correct assignment when corresponding files were touched by commit c5377a8

Changed modules: ['Generic Runtime', 'Torch Models', 'Torch Models DeepSeekV3', 'Triton Backend']

Module assignments:
  Generic Runtime: ['pcastonguay', 'MartinMarciniszyn']
  Torch Models: ['QiJune', 'hlu1']
  Torch Models DeepSeekV3: ['zongfeijing', 'hlu1']
  Triton Backend: ['schetlur-nv', 'Tabrizian']

Final reviewers to assign: ['MartinMarciniszyn', 'QiJune', 'Tabrizian', 'hlu1', 'pcastonguay', 'schetlur-nv', 'zongfeijing']
✅ Successfully assigned 7 new reviewer(s)

Removing auto-assigned reviewers (as this isn't a real PR)

@venkywonka venkywonka force-pushed the user/venky/actions branch from 0efbd83 to 9ac7371 Compare July 25, 2025 01:17
@venkywonka venkywonka deleted the branch NVIDIA:user/venky/actions August 27, 2025 18:36
@venkywonka venkywonka closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@venkywonka