Skip to content

[mock] [test-github-workflow] Check if PR-checklist workflow is triggered correctly #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
venkywonka wants to merge 52 commits into from
Closed

[mock] [test-github-workflow] Check if PR-checklist workflow is triggered correctly #6030

venkywonka wants to merge 52 commits into from

Conversation

@venkywonka
Copy link
Collaborator

@venkywonka venkywonka commented Jul 14, 2025

No description provided.

venkywonka added 30 commits June 30, 2025 10:47
@venkywonka
first commit
00b419e 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
add some more module-owners/modules
40a7385 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
bug fix
fa9face 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
use default permissions in action
4786bd9 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
use new REVIEW_ASSIGNING_TOKEN secret
6e84969 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
pull_request->pull_request_target to access secrets
8f61bb0 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
dry run changes
c32a374 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Enhance auto-reviewer assignment with duplicate prevention and better UX
405f0d3 
- Add logic to check existing reviewers before assignment
- Skip auto-assignment if reviewers already exist (unless --force-assign)
- Improve logging and error handling with status messages
- Add force-assign option for manual override
- Switch back to pull_request trigger for proper access
- Fix workflow parameter handling for force_assign option

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Switch to pull_request_target for secret access
64438f5 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Add explicit permissions for pull request writes and secret access
d1a39b0 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Switch from pull_request_target to pull_request trigger
decd175
@venkywonka
Add auto-assign feature in github actions for PRs
5c8b292 
- Add logic to check existing reviewers before assignment
- Skip auto-assignment if reviewers already exist (unless --force-assign)
- Improve logging and error handling with status messages
- Add force-assign option for manual override
- Switch back to pull_request trigger for proper access
- Fix workflow parameter handling for force_assign option

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
docs: add detailed auto-assign PR reviewer documentation
e11ccf9 
Add comprehensive documentation about the GitHub action for automatic
PR reviewer assignment, including its behavior with CODEOWNERS,
module-based assignment, and existing reviewer respect.

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
add comprehensive testing, change to pull_request_target
9be3f69 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
fix: Major module mapping overhaul for auto-assign reviewers
63339cd 
- Replace broad 'CI/CD' with 5 granular modules
- Separate test concerns from pipeline logic
- Move module-owners.json to .github/ for consistency

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
first commit
7829374 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
add some more module-owners/modules
7091eaf 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
bug fix
52713d2 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
use default permissions in action
8435ff0 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
use new REVIEW_ASSIGNING_TOKEN secret
e58fe23 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
pull_request->pull_request_target to access secrets
89322bf 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
dry run changes
9d78b23 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Enhance auto-reviewer assignment with duplicate prevention and better UX
831501f 
- Add logic to check existing reviewers before assignment
- Skip auto-assignment if reviewers already exist (unless --force-assign)
- Improve logging and error handling with status messages
- Add force-assign option for manual override
- Switch back to pull_request trigger for proper access
- Fix workflow parameter handling for force_assign option

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Switch to pull_request_target for secret access
d5cdb65 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Add explicit permissions for pull request writes and secret access
a2814d3 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Switch from pull_request_target to pull_request trigger
26e4546
@venkywonka
Merge fork-user/venky/auto-assign-pr-test into origin-user/venky/auto…
af43fd9 
…-assign-pr-test

Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Fix CONTRIBUTING.md to match fork version completely
192a3be 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Complete merge with remote user/venky/auto-assign-pr-test changes
c448fba 
Signed-off-by: Venky Ganesh <[email protected]>
@venkywonka
Enhanced assign_reviewers.py with detailed feedback for unmapped file…
18683e3 
…s and modules

- Modified map_modules() to return both modules and unmapped files
- Enhanced gather_reviewers() to track modules without owners
- Added comprehensive feedback when no reviewers are assigned:
  - Warns about files with no module mapping
  - Warns about modules with no owners
  - Explains specific reasons for no assignment
  - Provides actionable guidance for fixing coverage gaps
- Updated test cases to cover new functionality
- Added test cases for unmapped files and modules without owners

Signed-off-by: Venky Ganesh <[email protected]>
@tensorrt-cicd tensorrt-cicd requested review from niukuo and tburt-nv July 15, 2025 01:20
@venkywonka venkywonka removed request for niukuo and tburt-nv July 15, 2025 01:20
@venkywonka venkywonka marked this pull request as draft July 15, 2025 01:20
@venkywonka venkywonka marked this pull request as ready for review July 15, 2025 01:21
@NVIDIA NVIDIA deleted a comment from github-actions bot Jul 15, 2025
@venkywonka venkywonka marked this pull request as draft July 15, 2025 01:21
@venkywonka venkywonka marked this pull request as ready for review July 15, 2025 01:22
@NVIDIA NVIDIA deleted a comment from github-actions bot Jul 15, 2025
@tensorrt-cicd tensorrt-cicd requested review from niukuo and tburt-nv July 15, 2025 02:05
@venkywonka venkywonka removed request for niukuo and tburt-nv July 15, 2025 02:05
@venkywonka venkywonka marked this pull request as draft July 15, 2025 02:05
@venkywonka venkywonka marked this pull request as ready for review July 15, 2025 02:06
@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited by venkywonka
Loading

🚀 PR Checklist

  • PR title follows format: [type] Description
  • PR description explains both what you're doing and why
  • Code conforms to coding conventions (see CODING_GUIDELINES.md)
  • Test cases added for new code
  • All existing tests pass
  • PR and commit messages cleaned up via git rebase -i

Please ✅ check the below item to confirm you've reviewed the checklist when ready for review!.

  • I have reviewed the above checklist and addressed all applicable items.

@venkywonka venkywonka force-pushed the user/venky/actions branch from 0efbd83 to 9ac7371 Compare July 25, 2025 01:17
@venkywonka venkywonka requested review from a team as code owners August 19, 2025 18:34
@venkywonka venkywonka requested review from poweiw and yuanjingx87 and removed request for a team August 19, 2025 18:34
@venkywonka venkywonka deleted the branch NVIDIA:user/venky/actions August 27, 2025 18:36
@venkywonka venkywonka closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poweiw poweiw Awaiting requested review from poweiw poweiw was automatically assigned from NVIDIA/trt-llm-gh-workflows-infra-devs

@yuanjingx87 yuanjingx87 Awaiting requested review from yuanjingx87 yuanjingx87 was automatically assigned from NVIDIA/trt-llm-infra-devs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@venkywonka