Skip to content

Conversation

@chuangz0
Copy link
Collaborator

@chuangz0 chuangz0 commented Nov 4, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced memory management during executor initialization to prevent potential resource conflicts and improve stability.
  • Tests

    • Removed outdated entries from the integration test waives list to maintain test suite accuracy.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chuangz0 chuangz0 requested a review from a team as a code owner November 4, 2025 06:31
@chuangz0 chuangz0 force-pushed the fix_kv_cache_transceiver branch from 10413fc to 8fc818c Compare November 4, 2025 06:34
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Nov 4, 2025

/bot run --add-multi-gpu-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

📝 Walkthrough

Walkthrough

Adds garbage collection to the PyExecutor initialization to free memory before constructing the final executor, reducing CUDA graph capture overlap. Simultaneously removes two test entries from the integration test waives list.

Changes

Cohort / File(s) Summary
Memory optimization in PyExecutor initialization
tensorrt_llm/_torch/pyexecutor/py_executor_creator.py
Imports gc module and adds gc.collect() call in the drafting-extra-resources finalization block to prevent CUDA memory overlap with prior allocations during executor construction
Integration test waives list maintenance
tests/integration/test_lists/waives.txt
Removes two test entries: TestQwen3_8B::test_nixl_backend and TestDeepSeekV3Lite::test_guided_decoding[xgrammar-mtp_nextn=2] from the disaggregated serving test waives

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete with placeholder template sections and no substantive content filled in. Replace @coderabbitai summary placeholder with actual PR title. Complete Description, Test Coverage sections with specific details about the changes and testing approach.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required template with NVBugs ticket format and [fix] type, clearly describing the main change to avoid CUDA free overlaps with CUDA graphs.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chuangz0 chuangz0 requested a review from Shixiaowei02 November 4, 2025 06:40
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23476 [ run ] triggered by Bot. Commit: 8fc818c

@Shixiaowei02 Shixiaowei02 requested a review from kaiyux November 4, 2025 08:37
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23476 [ run ] completed with state SUCCESS. Commit: 8fc818c
/LLM/release-1.1/L0_MergeRequest_PR pipeline #402 completed with status: 'FAILURE'

@chuangz0 chuangz0 force-pushed the fix_kv_cache_transceiver branch from 8fc818c to e409ad3 Compare November 4, 2025 12:03
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Nov 4, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23508 [ run ] triggered by Bot. Commit: e409ad3

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23508 [ run ] completed with state SUCCESS. Commit: e409ad3
/LLM/release-1.1/L0_MergeRequest_PR pipeline #409 completed with status: 'FAILURE'

@chuangz0 chuangz0 force-pushed the fix_kv_cache_transceiver branch from e409ad3 to 01748d1 Compare November 5, 2025 06:30
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Nov 5, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23599 [ run ] triggered by Bot. Commit: 01748d1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23599 [ run ] completed with state SUCCESS. Commit: 01748d1
/LLM/release-1.1/L0_MergeRequest_PR pipeline #426 completed with status: 'FAILURE'

@chuangz0 chuangz0 force-pushed the fix_kv_cache_transceiver branch from 01748d1 to 6e7cb4a Compare November 5, 2025 10:21
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Nov 5, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23639 [ run ] triggered by Bot. Commit: 6e7cb4a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants