Skip to content

Conversation

@byshiue
Copy link
Collaborator

@byshiue byshiue commented Nov 4, 2025

Summary by CodeRabbit

  • Chores
    • Added configuration file with system parameters including scheduling options, logging settings, acceleration configurations, and backend selections.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@byshiue byshiue requested a review from a team as a code owner November 4, 2025 14:01
@byshiue
Copy link
Collaborator Author

byshiue commented Nov 4, 2025

/bot run --post-merge --stage-list "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

📝 Walkthrough

Walkthrough

A new configuration file tmp.txt is added containing settings for scheduler behavior, logging, attention mechanisms, CUDA graph batch size optimization, and mixture-of-experts backend selection.

Changes

Cohort / File(s) Change Summary
New configuration file
tmp.txt
Adds configuration parameters: disable_overlap_scheduler, print_iter_log, enable_attention_dp, cuda_graph_config with batch sizes, and moe_config specifying DEEPGEMM backend

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify configuration keys are valid and match expected schema
  • Confirm batch size values in cuda_graph_config are reasonable and ordered
  • Check if tmp.txt is intended as permanent configuration or should be .gitignored

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is essentially empty—it contains only the template structure with commented instructions and bot help documentation, but lacks any actual content for Description, Test Coverage, or meaningful checklist completion. Fill in the Description section explaining the CI issue and how tmp.txt resolves it, list relevant tests under Test Coverage, and complete the PR Checklist items appropriately for this change.
Title check ❓ Inconclusive The title follows the required format with NVBugs ticket ID and [fix] type, but 'debug the CI issue' is vague and doesn't clearly summarize the specific change (adding tmp.txt configuration file). Clarify the title to specifically describe what the CI fix involves, e.g., '[https://nvbugs/5631036][fix] Add configuration file for CI debugging' or provide more specific details about what CI issue is being resolved.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cacb8a8 and f608dd4.

📒 Files selected for processing (1)
  • tmp.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tmp.txt (1)

1-8: Review comment is based on incorrect assumptions about the branch and file purpose.

The file is intentionally added to the coderabbit_8912 feature branch (not release/1.1 as claimed) with explicit purpose documented in the commit message: "add a dummy file to launch CI." This is a recognized pattern in the TensorRT-LLM codebase—dummy files are legitimately used for CI orchestration and testing, as evidenced by multiple prior commits referencing dummy loads, dummy requests, and dummy weights. The file placement and naming convention are appropriate for this use case.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23512 [ run ] triggered by Bot. Commit: f608dd4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23512 [ run ] completed with state SUCCESS. Commit: f608dd4
/LLM/release-1.1/L0_MergeRequest_PR pipeline #411 (Partly Tested) completed with status: 'SUCCESS'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants