Skip to content

Conversation

@SimengLiu-nv
Copy link
Collaborator

@SimengLiu-nv SimengLiu-nv commented Nov 4, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Improved compatibility with PyTorch 2.9.0 and later versions.
  • Chores

    • Removed obsolete test entries.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@SimengLiu-nv SimengLiu-nv marked this pull request as ready for review November 4, 2025 18:42
@SimengLiu-nv SimengLiu-nv requested a review from a team as a code owner November 4, 2025 18:42
@SimengLiu-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast --extra-stage "A100X-Triton-Post-Merge-1, A100X-Triton-Post-Merge-2"

@SimengLiu-nv SimengLiu-nv changed the title Fix torch.onnx.export with pytorch upgrade to fallback to dynamo=False. [https://nvbugs/5606136][fix]Fix torch.onnx.export with pytorch upgrade to fallback to dynamo=False. Nov 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

📝 Walkthrough

Walkthrough

The changes add dynamo=False parameter to ONNX export calls across three files to prevent Dynamo-related issues with PyTorch >= 2.9.0, and remove multiple test waiver entries for mistral small 3.1 24B pixtral models from the waives.txt file.

Changes

Cohort / File(s) Summary
ONNX Export Configuration Updates
examples/models/contrib/dit/vae_decoder_trt.py, examples/models/core/qwenvl/vit_onnx_trt.py, tensorrt_llm/tools/multimodal_builder.py
Adds dynamo=False parameter to torch.onnx.export calls with explanatory comments referencing PyTorch >= 2.9.0 compatibility issues related to opset_version=17 and Dynamo.
Test Waiver Removal
tests/integration/test_lists/waives.txt
Removes multiple SKIP waiver entries for mistral small 3.1 24B pixtral model variants, including configurations differentiated by precision (FP16/BF16), decouple/inflight flags, and other optimization settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Consistent, repetitive pattern: same parameter addition across three files with identical rationale
  • Straightforward test waiver removals with clear intent
  • No complex logic changes or control flow modifications
  • Low risk of behavioral impact given homogeneous nature of edits

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete, containing only the template guidance without actual content. Required sections like Description, Test Coverage, and PR Checklist are not filled with meaningful information. Fill in the Description section explaining the PyTorch 2.9.0 Dynamo issue and why dynamo=False is needed. Add Test Coverage section detailing the tests that validate this fix.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: fixing torch.onnx.export calls by adding dynamo=False to handle PyTorch 2.9.0+ compatibility issues.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23535 [ run ] triggered by Bot. Commit: bd1037d

@SimengLiu-nv SimengLiu-nv changed the title [https://nvbugs/5606136][fix]Fix torch.onnx.export with pytorch upgrade to fallback to dynamo=False. [https://nvbugs/5606136][fix] Fix torch.onnx.export with pytorch upgrade to fallback to dynamo=False. Nov 4, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23535 [ run ] completed with state SUCCESS. Commit: bd1037d
/LLM/release-1.1/L0_MergeRequest_PR pipeline #414 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@SimengLiu-nv SimengLiu-nv merged commit 0206d8d into NVIDIA:release/1.1 Nov 4, 2025
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants