[TRTLLM-9514][infra] Support Build Docker Images and Test CI in one pipeline #9403
Conversation
|
/bot run --disable-multi-gpu-test --skip-test |
📝 WalkthroughWalkthroughAdded CI-focused build mode to Jenkins Docker image pipeline. When MODE is set to "build_for_ci", the pipeline executes a new updateCIImageTag stage, restricts build configurations to CI entries, suppresses non-CI stages, and handles Git metadata for signed commits with CI-specific image tag updates. Changes
Sequence Diagram(s)sequenceDiagram
participant Pipeline
participant buildImage as buildImage()
participant launchBuildJobs as launchBuildJobs()
participant updateCIImageTag as updateCIImageTag()
participant Git as Git/GitHub
Pipeline->>Pipeline: Check MODE variable
alt MODE == "build_for_ci"
Pipeline->>buildImage: Filter configs to CI entries only
activate buildImage
buildImage->>buildImage: Build CI images
deactivate buildImage
Pipeline->>launchBuildJobs: Launch CI-specific jobs
activate launchBuildJobs
launchBuildJobs->>launchBuildJobs: Execute CI configs
deactivate launchBuildJobs
Pipeline->>updateCIImageTag: New stage: Update CI Image Tag
activate updateCIImageTag
updateCIImageTag->>Git: Parse Signed-off-by from commit
updateCIImageTag->>Git: Configure git user
updateCIImageTag->>Git: Compute CI image tags
updateCIImageTag->>Git: Update current_image_tags.properties
updateCIImageTag->>Git: Push to forked branch
deactivate updateCIImageTag
else MODE != "build_for_ci"
Pipeline->>Pipeline: Execute standard pipeline flow
Pipeline->>Pipeline: Include all stages (Artifacts, Sanity, Security, etc.)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (4)
jenkins/BuildDockerImage.groovy (4)
500-500: Duplicate assignment of stageName.The
stageNameis set here at line 500 and again at line 510 within the buildJobs closure. The second assignment is redundant since the config object already has this property set.Consider removing the duplicate assignment at line 510:
stage(key) { - config.stageName = key try {
554-573: Add validation for file existence.The function uses
readFilewithout checking if the file exists, which could result in unclear error messages if the properties file is missing.Add a file existence check:
def filePath = "jenkins/current_image_tags.properties" + if (!fileExists(filePath)) { + error "Properties file not found: ${filePath}" + } + echo "Updating ${filePath} with new image tags"
599-622: Consider more robust Signed-off-by parsing.The regex pattern
/(.*)<(.+)>/may not handle all valid Signed-off-by formats (e.g., missing angle brackets, extra whitespace). While the error handling provides fallback behavior, more robust parsing or additional logging would improve reliability.Consider adding validation or logging of the parsed values:
def signedEmail = matcher[0][2].trim() // Set git config user.name and user.email to match Signed-off-by for signed commit consistency if (signedName && signedEmail) { echo "Setting git config user.name to '${signedName}' and user.email to '${signedEmail}' for consistency with Signed-off-by" + // Validate email format + if (!signedEmail.contains('@')) { + echo "Warning: parsed email '${signedEmail}' does not appear valid, using defaults" + return + } sh """
629-631: Add retry logic for git push.The git push operation has no error handling or retry logic. Network issues or transient failures could cause the entire pipeline to fail unnecessarily.
Consider using
llmExecStepWithRetryfor the push operation, similar to other network operations in the pipeline:// Push the changes to the user fork's branch - sh """ - git push fork HEAD:${currentBranch} - """ + def pushScript = """ + cd ${LLM_ROOT} + git push fork HEAD:${currentBranch} + """ + trtllm_utils.llmExecStepWithRetry(this, script: pushScript, numRetries: 3)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
jenkins/BuildDockerImage.groovy(8 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (6)
jenkins/BuildDockerImage.groovy (6)
36-37: Hard-coded MODE override bypasses parameter.Line 37 overrides the MODE parameter with a hard-coded value
"build_for_ci", effectively disabling normal mode regardless of the parameter input. The TODO comment suggests this is temporary.Please confirm when this override should be removed to restore normal parameter-driven behavior.
337-339: LGTM!The conditional logic correctly tracks CI image tags using the stage name as the key, consistent with the NGC image tracking pattern above.
487-492: LGTM!The filtering logic correctly restricts build configurations to CI-related entries when in
build_for_cimode, matching the config keys defined earlier.
703-714: LGTM!The new pipeline stage is correctly structured with an appropriate conditional guard for CI build mode.
716-720: LGTM!The conditional correctly skips artifact upload when in CI build mode, which is appropriate given that the CI mode has its own output mechanism.
734-734: LGTM!The additional
MODE != "build_for_ci"conditions correctly skip post-build stages (waiting for artifacts, sanity checks, and security registration) that are not applicable to CI image builds.Also applies to: 795-795, 831-831
|
PR_Github #25529 [ run ] triggered by Bot. Commit: |
|
PR_Github #25529 [ run ] completed with state |
|
/bot run --disable-multi-gpu-test --skip-test |
|
PR_Github #25543 [ run ] triggered by Bot. Commit: |
|
PR_Github #25543 [ run ] completed with state |
|
PR_Github #5 [ run ] triggered by Bot. Commit: |
|
PR_Github #5 [ run ] completed with state |
|
@ZhanruiSunCh is this PR meant for review? I see the subject is "Test". |
Not, Sorry, I forget add Draft for it. |
|
PR_Github #17 [ run ] triggered by Bot. Commit: |
|
PR_Github #17 [ run ] completed with state |
|
/bot run --disable-multi-gpu-test --skip-test |
|
PR_Github #26127 [ run ] triggered by Bot. Commit: |
|
PR_Github #26127 [ run ] completed with state |
|
PR_Github #18 [ run ] triggered by Bot. Commit: |
|
PR_Github #18 [ run ] completed with state |
|
PR_Github #19 [ run ] triggered by Bot. Commit: |
|
PR_Github #19 [ run ] completed with state |
|
PR_Github #20 [ run ] triggered by Bot. Commit: |
|
PR_Github #20 [ run ] completed with state |
|
PR_Github #21 [ run ] triggered by Bot. Commit: |
|
PR_Github #21 [ run ] completed with state |
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: tensorrt-cicd <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: tensorrt-cicd <[email protected]>
Signed-off-by: tensorrt-cicd <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: tensorrt-cicd <[email protected]>
Signed-off-by: tensorrt-cicd <[email protected]>
ZhanruiSunCh
force-pushed
the
user/zhanruis/1120_support_build_image_and_test_it
branch
from
65b8d94 to
3c1b71f
Compare
|
PR_Github #76 [ run ] triggered by Bot. Commit: |
|
PR_Github #76 [ run ] completed with state |
Signed-off-by: tensorrt-cicd <[email protected]>
|
PR_Github #77 [ run ] triggered by Bot. Commit: |
|
PR_Github #77 [ run ] completed with state |
3 participants
Summary by CodeRabbit
Release Notes
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.