[TRTLLM-9522][fix] broken cast

[ixlmar]

Description

Fixes a broken typing.cast introduced by #9664. The corresponding unit tests in #9963 are delayed by issues with the multi-GPU test stages.

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

• Bug Fixes
  • Corrected type handling in multimodal embedding processing to ensure proper type casting.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[ixlmar]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

Fixes a type casting argument order error in the multimodal embedding path within asynchronous generation flow. The cast() call arguments were swapped from cast(self.input_processor, BaseMultimodalInputProcessor) to the correct order, with corresponding argument reordering in the subsequent function call.

Changes

Cohort / File(s)	Summary
Casting argument order fix tensorrt_llm/llmapi/llm.py	Corrected reversed cast() arguments in multimodal embedding handling: swapped argument order and reordered corresponding function call parameters for proper type handling

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the main change: fixing a broken cast in the codebase, matching the core fix described in the raw summary.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check	✅ Passed	The PR description is minimal but adequately addresses the core issue with a reference to the related PR that introduced the bug and mentions delayed tests.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #28153 [ run ] triggered by Bot. Commit: 0b6977f

[tensorrt-cicd]

PR_Github #28153 [ run ] completed with state SUCCESS. Commit: 0b6977f
/LLM/main/L0_MergeRequest_PR pipeline #21509 completed with status: 'FAILURE'

[ixlmar]

/bot run

[tensorrt-cicd]

PR_Github #30596 [ run ] triggered by Bot. Commit: cbb3fb2

[tensorrt-cicd]

PR_Github #30596 [ run ] completed with state FAILURE. Commit: cbb3fb2
/LLM/main/L0_MergeRequest_PR pipeline #23606 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[ixlmar]

/bot run

[tensorrt-cicd]

PR_Github #30701 [ run ] triggered by Bot. Commit: cbb3fb2

[tensorrt-cicd]

PR_Github #30701 [ run ] completed with state SUCCESS. Commit: cbb3fb2
/LLM/main/L0_MergeRequest_PR pipeline #23689 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #30736 [ run ] triggered by Bot. Commit: cbb3fb2

[tensorrt-cicd]

PR_Github #30736 [ run ] completed with state SUCCESS. Commit: cbb3fb2
/LLM/main/L0_MergeRequest_PR pipeline #23719 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #30865 [ run ] triggered by Bot. Commit: cbb3fb2

[tensorrt-cicd]

PR_Github #30865 [ run ] completed with state SUCCESS. Commit: cbb3fb2
/LLM/main/L0_MergeRequest_PR pipeline #23830 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #31026 [ run ] triggered by Bot. Commit: cbb3fb2

[ixlmar]

The incorrect usage of typing.cast in the base branch has gone unnoticed for some time, corroborating that no CI tests cover the code changed by this PR. Also, all but a few x64 multi-GPU test stages have completed successfully and the remaining issues seen in CI appear unrelated to the changes made in this PR.

Proceeding with merge to remove the bug from main. The tests included in #9963 and #9715 should add coverage for the relevant code as soon as those PRs get merged.

[ixlmar]

/bot skip --comment "PR changes not covered by multi-GPU tests and all other stages passed"

[tensorrt-cicd]

PR_Github #31058 [ skip ] triggered by Bot. Commit: cbb3fb2

[tensorrt-cicd]

PR_Github #31058 [ skip ] completed with state SUCCESS. Commit: cbb3fb2
Skipping testing for commit cbb3fb2