Skip to content

fix: update tests_eagle.py; disable eval for offline #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

fix: update tests_eagle.py; disable eval for offline #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e5ac0a
fix: update tests_eagle.py; disable eval for offline
h-guo18 Sep 23, 2025
98c4de4
update test_medusa.py
h-guo18 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/speculative_decoding/launch_train.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ if [[ "$OFFLINE_DATA_PATH" != "" ]]; then
echo "Offline data path $OFFLINE_DATA_PATH does not exist or is not a directory."
exit 1
else
OFFLINE_TRAINING_ARGS="--offline-data-path $OFFLINE_DATA_PATH"
OFFLINE_TRAINING_ARGS="--offline-data-path $OFFLINE_DATA_PATH --ar_validate_steps -1"
fi
else
OFFLINE_TRAINING_ARGS=""
Expand Down
3 changes: 1 addition & 2 deletions tests/examples/speculative_decoding/test_eagle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,11 @@ def test_llama_eagle3(tiny_llama_path, num_gpus, tiny_daring_anteater_path, tmp_

run_example_command(
[
"./launch.sh",
"./launch_train.sh",
"--model", tiny_llama_path,
"--data", tiny_daring_anteater_path,
"--num_epochs", "1",
"--lr", "1e-5",
"--do_eval", "False",
"--num_gpu", str(num_gpus),
"--mode", "eagle3",
"--eagle_config", str(config_file),
Expand Down
3 changes: 1 addition & 2 deletions tests/examples/speculative_decoding/test_medusa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,11 @@ def test_llama_medusa_fp8_qat(tiny_llama_path, num_gpus, tiny_daring_anteater_pa
# Test Medusa
run_example_command(
[
"./launch.sh",
"./launch_train.sh",
"--model", tiny_llama_path,
"--data", tiny_daring_anteater_path,
"--num_epochs", "1",
"--lr", "1e-5",
"--do_eval", "False",
"--num_gpu", str(num_gpus),
"--mode", "medusa",
"--output_dir", medusa_path,
Expand Down
Loading