-
Notifications
You must be signed in to change notification settings - Fork 169
Remove Qwen tokenizer modification #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chenjie Luo <[email protected]>
WalkthroughRemoved Qwen-specific pad/eos token adjustments across multiple tokenizer initialization paths. Affected scripts continue initializing models and tokenizers without inferring model type from checkpoint directories. No public APIs changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 73.86% 73.85% -0.01%
==========================================
Files 171 171
Lines 17629 17629
==========================================
- Hits 13021 13020 -1
- Misses 4608 4609 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Chenjie Luo <[email protected]>
What does this PR do?
Bug fix
Overview: ?
The newer qwen models such as qwen3 and qwen2.5VL does not require tokenizer modification anymore.
Summary by CodeRabbit
Refactor
Chores
Notes