-
Notifications
You must be signed in to change notification settings - Fork 169
Set git commit signing on in .vscode/settings.json #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Keval Morabia <[email protected]>
WalkthroughVSCode workspace settings were updated by adding two Git configuration keys: git.alwaysSignOff and git.enableCommitSigning, both set to true. No other settings were modified or removed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.vscode/settings.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: linux
- GitHub Check: code-quality
- GitHub Check: build-docs
🔇 Additional comments (1)
.vscode/settings.json (1)
45-45
: LGTM: Trailing comma added for consistency.The trailing comma after the array ensures easier future additions without having to modify this line.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 73.86% 73.86%
=======================================
Files 171 171
Lines 17629 17629
=======================================
Hits 13021 13021
Misses 4608 4608 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We see first time contributors often forgetting to sign-off their commits hence making commit signing default in vscode workspace settings to reduce such issues
Summary by CodeRabbit