Skip to content

Conversation

kevalmorabia97
Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 commented Sep 29, 2025

We see first time contributors often forgetting to sign-off their commits hence making commit signing default in vscode workspace settings to reduce such issues

Summary by CodeRabbit

  • Chores
    • Updated workspace settings to require signed commits and automatically add sign-offs when committing from VS Code. This improves commit integrity and consistency for contributors working in this repository. No impact on application functionality or UI. End users do not need to take any action or change their configuration.

Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

VSCode workspace settings were updated by adding two Git configuration keys: git.alwaysSignOff and git.enableCommitSigning, both set to true. No other settings were modified or removed.

Changes

Cohort / File(s) Summary
VSCode workspace settings
.vscode/settings.json
Added git.alwaysSignOff: true and git.enableCommitSigning: true to the workspace settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

In the repo’s burrow, neat and tight,
I toggled two flags to sign just right.
A whisker’s twitch, commits now sing,
With tidy paws, I press the spring.
Hop-sign-off—my favorite thing! 🐰✍️

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Set git commit signing on in .vscode/settings.json" accurately describes the main change in the changeset. The raw summary confirms that two Git-related settings are being added to the VSCode workspace configuration: always sign off on commits and enable commit signing. The title is concise, clear, and directly reflects the primary modification being made to the repository's VSCode settings file.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kmorabia/git-signing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 677bc10 and d3cd060.

📒 Files selected for processing (1)
  • .vscode/settings.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: linux
  • GitHub Check: code-quality
  • GitHub Check: build-docs
🔇 Additional comments (1)
.vscode/settings.json (1)

45-45: LGTM: Trailing comma added for consistency.

The trailing comma after the array ensures easier future additions without having to modify this line.

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.86%. Comparing base (615f3c0) to head (d3cd060).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   73.86%   73.86%           
=======================================
  Files         171      171           
  Lines       17629    17629           
=======================================
  Hits        13021    13021           
  Misses       4608     4608           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97 kevalmorabia97 merged commit 8d924d3 into main Sep 30, 2025
27 checks passed
@kevalmorabia97 kevalmorabia97 deleted the kmorabia/git-signing branch September 30, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant