-
Notifications
You must be signed in to change notification settings - Fork 190
Fix multi-gpu mamba minitron param sorting test + minor cleanup #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughCI matrix updated to include Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Test as Test (unit)
participant Model as DynamicSpace / Model
participant Util as mtn.utils.sort_parameters
Note over Test,Model: Before -> in-place call (old)
Test->>Model: dynamic_space.sort_parameters()
Model-->>Test: parameters sorted
Note over Test,Util: After -> centralized utility (new)
Test->>Util: mtn.utils.sort_parameters(model)
Util-->>Test: parameters sorted
sequenceDiagram
autonumber
participant Importer as plugin __init__
participant MegatronConfig as megntron_model_config
participant Plugin as megatron plugin
Note over Importer,MegatronConfig: Old (before)
Importer->>MegatronConfig: from .megatron_model_config import *
MegatronConfig-->>Importer: symbols re-exported
Note over Importer,Plugin: New (after)
Importer->>Plugin: plugin init without star-import
Plugin-->>Importer: no direct re-exports from megatron_model_config
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 73.79% 73.79%
=======================================
Files 171 171
Lines 17591 17591
=======================================
Hits 12982 12982
Misses 4609 4609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6ffe2d8 to
4f0057a
Compare
Signed-off-by: Keval Morabia <[email protected]>
4f0057a to
4e1067a
Compare
What does this PR do?
Summary by CodeRabbit
Style
Tests
Documentation
Refactor