Skip to content

Conversation

@jingyu-ml
Copy link
Contributor

@jingyu-ml jingyu-ml commented Oct 11, 2025

What does this PR do?

Type of change: Minor code change

Overview: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

Summary by CodeRabbit

  • Chores
    • Restricts the transformers version used by the cache diffusion example to below 4.57.
    • Improves out-of-the-box setup for the cache diffusion example by tightening example dependency constraints.
    • No changes to core application behavior; impact limited to example environment configuration.

@jingyu-ml jingyu-ml requested a review from a team as a code owner October 11, 2025 03:11
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 11, 2025

Walkthrough

Adds a single dependency constraint line transformers<4.57 to examples/diffusers/cache_diffusion/requirements.txt; no other files or code paths changed.

Changes

Cohort / File(s) Summary
Requirements edit
examples/diffusers/cache_diffusion/requirements.txt
Appended a constraint: transformers<4.57 after sentencepiece. No deletions or other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hop through lines and plant a seed,
A tiny cap on versions we need.
transformers trimmed, neat and small,
No other files touched at all—🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly captures the primary purpose of the changeset by indicating a fix to the CI/CD process for the cache diffusion example, which aligns with the added dependency constraint aimed at resolving build issues in that workflow.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jingyux/cache.diffusion.cicd.fixed

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 041b748 and 0559a73.

📒 Files selected for processing (1)
  • examples/diffusers/cache_diffusion/requirements.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: linux
  • GitHub Check: code-quality
  • GitHub Check: build-docs
🔇 Additional comments (1)
examples/diffusers/cache_diffusion/requirements.txt (1)

6-6: LGTM on the pin.

The <4.57 upper bound neatly guards us until the upstream diffusers fix lands; no further issues spotted.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99c44d3 and 3512d83.

📒 Files selected for processing (1)
  • examples/diffusers/cache_diffusion/requirements.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: linux
  • GitHub Check: code-quality
  • GitHub Check: build-docs
🔇 Additional comments (1)
examples/diffusers/cache_diffusion/requirements.txt (1)

7-7: Confirm the exact transformers version.

Double-check that a release tagged 4.49 exists; Hugging Face typically publishes patch-qualified versions (e.g., 4.49.0). If only 4.49.0 is available, please pin to that exact tag.

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.38%. Comparing base (9e64f81) to head (0559a73).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files         180      180           
  Lines       17934    17934           
=======================================
  Hits        13160    13160           
  Misses       4774     4774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 2 to 7
diffusers==0.32.2
opencv-python>=4.8.1.78,<4.12.0.88
peft>=0.10.0
polygraphy==0.49.9
sentencepiece
transformers==4.49
Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we think of a better solution with correctly passing model kwargs instead of pinning to a lower version?

Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only need transformers<4.57 since fix is merged in huggingface/diffusers#12438 and will be included in next 0.36 diffusers release after which we remove transformers pinned version and instead pin diffusers>=0.36.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I’ve updated it. I’ll make another update once the new version is released.

@kevalmorabia97
Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 merged commit 46a9e49 into main Oct 13, 2025
27 checks passed
@kevalmorabia97 kevalmorabia97 deleted the jingyux/cache.diffusion.cicd.fixed branch October 13, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants