Fix/Improve vllm PTQ and Support multi-node with ray #484
+310
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: mxin <[email protected]>
Signed-off-by: mxin <[email protected]>
mxinO
changed the title
mxinO
changed the title
realAsma
reviewed
Nov 4, 2025
There was a problem hiding this comment.
@mxinO does this maintain the support for non-ray + vLLM ?
realAsma
reviewed
Nov 4, 2025
Comment on lines
+186
to
+206
| model.load_state_dict(current_state_dict) | ||
| torch.distributed.barrier() | ||
|
|
||
| if amax_file_path is None: | ||
| # Sync amax across TP can be done here if needed | ||
| pass | ||
| # for name, buffer in model.named_buffers(): | ||
| # if name.endswith("_amax"): | ||
| # print("syncing amax across TP for", name) | ||
| # torch.distributed.all_reduce( | ||
| # buffer, op=torch.distributed.ReduceOp.MAX, group=get_tp_group().device_group | ||
| # ) | ||
| # torch.distributed.barrier() | ||
|
|
||
| if not torch.distributed.is_initialized() or torch.distributed.get_rank() == 0: | ||
| mtq.print_quant_summary(model) | ||
|
|
||
| mtq.fold_weight(model) | ||
| for name, module in model.named_modules(): | ||
| if name.endswith("weight_quantizer"): | ||
| assert not module.is_enabled, f"quantizer {name} is still enabled" |
There was a problem hiding this comment.
Do we need to do this under disable_compilation context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Overview:
Fix or improve the vllm PTQ.
SharedFusedMoEUsage
Testing
Tested with latest vllm.
Additional Information
The vllm >0.11.0 changed the low-level API significantly. Some changes needs to be removed when vllm<=0.11.0 is outdated.