Update benchmarking for diffusers #487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
+ Coverage 74.36% 74.39% +0.02%
==========================================
Files 181 182 +1
Lines 18192 18209 +17
==========================================
+ Hits 13529 13546 +17
Misses 4663 4663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Please make sure to run internal gitlab diffuesrs cicd test to verify they dont break with this change |
Signed-off-by: ajrasane <[email protected]>
ajrasane
force-pushed
the
ajrasane/benchmark_diffusers
branch
from
89f6c25 to
1aafbbc
Compare
Signed-off-by: ajrasane <[email protected]>
ajrasane
force-pushed
the
ajrasane/benchmark_diffusers
branch
from
094aa94 to
646458a
Compare
jingyu-ml
approved these changes
Nov 7, 2025
cjluo-nv
approved these changes
Nov 7, 2025
| def forward_hook(_module, _input, _output): | ||
| _ = backbone(**dummy_inputs_dict) | ||
| end_event.record() | ||
| torch.cuda.synchronize() |
Collaborator
There was a problem hiding this comment.
I don't think you need to call sync here.
|
|
||
| avg_latency = sum(times) / len(times) | ||
| times = sorted(times) | ||
| p50 = times[len(times) // 2] |
Collaborator
There was a problem hiding this comment.
I suggest you use numpy.percentile for these instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change:
Example update
Overview:
Testing
Before your PR is "Ready for review"