Skip to content

[5591945][ONNX] Fix 'nodes not sorted' failure #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[5591945][ONNX] Fix 'nodes not sorted' failure #507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911ffd1
Ensure nodes are topologically sorted
gcunhase Oct 23, 2025
623ceff
Remove 'cleanup()'
gcunhase Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modelopt/onnx/trt_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,11 @@ def load_onnx_model(
if intermediate_generated_files is not None:
intermediate_generated_files.append(ir_version_onnx_path)

# Ensure nodes are topologically sorted
Copy link
Contributor

@i-riyad i-riyad Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What operation(s) make the graph nodes "un-sorted"?

graph = gs.import_onnx(onnx_model)
graph.toposort()
onnx_model = gs.export_onnx(graph)

# Check that the model is valid
onnx.checker.check_model(onnx_model)

Expand Down
Loading