-
Notifications
You must be signed in to change notification settings - Fork 192
[NVBUG: 5619158] Enforce high precision model dtype for diffusion trt #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ajrasane <[email protected]>
1ead6d6 to
17e07d0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage 73.52% 73.52%
=======================================
Files 181 181
Lines 18207 18207
=======================================
Hits 13387 13387
Misses 4820 4820 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| model_dtype = None | ||
| if hasattr(pipe, "transformer"): | ||
| backbone = pipe.transformer | ||
| model_dtype = "Bfloat16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just use the dtype from the model or this has to be setup like the hardcoded way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have hardcoded the dtype in create_pipeline_from() function, so we will have to use this in the hardcoded way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ajrasane <[email protected]>
Signed-off-by: ajrasane <[email protected]>
3bb45e6 to
80a128d
Compare
What does this PR do?
Type of change:
Minor code change
Overview:
Testing
Before your PR is "Ready for review"