-
Notifications
You must be signed in to change notification settings - Fork 603
[PyTorch] Documentation for op fuser API #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
Greptile OverviewGreptile SummaryThis PR adds comprehensive documentation for the operation fuser API, a "bottom-up" alternative to Transformer Engine's monolithic modules that allows users to construct and fuse individual operations flexibly. Key ChangesNew Documentation (251 lines)
API Documentation Updates
Docstring Fixes (15 files)
Minor Fixes
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Sequential
participant OperationFuser
participant BasicOps
participant FusedOps
User->>Sequential: forward(input)
Sequential->>Sequential: _make_module_groups()
Sequential->>OperationFuser: __call__(input)
OperationFuser->>OperationFuser: maybe_fuse_ops()
OperationFuser->>BasicOps: Analyze fusion opportunities
OperationFuser->>FusedOps: Create fused operations
FusedOps->>BasicOps: fuser_forward()
BasicOps-->>FusedOps: output
FusedOps-->>OperationFuser: output
OperationFuser-->>Sequential: output
Sequential-->>User: output
|
Signed-off-by: Tim Moon <[email protected]>
Review suggestion from @greptile-apps Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Tim Moon <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Tim Moon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
transformer_engine/pytorch/ops/basic/activation.py, line 387 (link)syntax: Extra space before period.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
19 files reviewed, 1 comment
Signed-off-by: Tim Moon <[email protected]>
|
/te-ci core pytorch |
Signed-off-by: Tim Moon <[email protected]>
Signed-off-by: Tim Moon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
Description
This PR adds a basic usage guide for the op fuser and includes it in the autogenerated API docs.
It is ready as-is, but if reviews take a while I may expand it with a guide on creating custom fused ops.
Type of change
Changes
Checklist: