Closed
Conversation
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
jwilber
requested review from
broland-hat,
dorotat-nv,
jstjohn,
polinabinder1,
pstjohn,
trvachov and
tshimko-nv
as code owners
jwilber
requested review from
cspades,
jomitchellnv and
yzhang123
as code owners
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Collaborator
Author
|
/ok to test a1213b4 |
@jwilber, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
tshimko-nv
approved these changes
Jul 31, 2025
Collaborator
Author
|
/ok to test 7e20d93 |
Collaborator
|
gotta bring back my JSX knowledge here |
docs/interactives/code/illustrated-evo2/src/components/Barplot/DataBarplot.css
Show resolved
Hide resolved
docs/interactives/code/illustrated-evo2/src/components/Barplot/VerticalBarplot.jsx
Show resolved
Hide resolved
| @@ -0,0 +1,141 @@ | |||
| /* | |||
| .grid-container { | |||
trvachov
pushed a commit
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds the interactives to our docs. They should build fine with the current setup.
We have a new folder,
docs/interactives/where they will be held. Namely:docs/interactives/code/will hold the code for a given article, e.g.docs/interactives/code/illustrated-evo2/holds the code for the Evo 2 article.docs/interactives/static/will hold the generated, optimized bundled assets for a given article, e.g.docs/interactives/static/illustrated-evo2/holds the code for the Evo 2 article used to render the article.In other words, for any future interactive content, we'd just put the article in it's own dir in
code/, and set the bundle to be output to the same dir instatic/.To make this possible, I added a new hook that grabs the bundled assets and moves them into the site dir where docs are rendered.
There are a lot of file changes in the diff here, but these are really what is relevant (non-article code):