Skip to content

fix mdformat version at 3.9#1087

Closed
jwilber wants to merge 1 commit intomainfrom
jwilber/force-mdformat-3.9
Closed

fix mdformat version at 3.9#1087
jwilber wants to merge 1 commit intomainfrom
jwilber/force-mdformat-3.9

Conversation

@jwilber
Copy link
Collaborator

@jwilber jwilber commented Aug 28, 2025

Fix mdformat version at 3.9

Summary by CodeRabbit

  • Chores
    • Updated development tooling to run the Markdown formatting hook with Python 3.9 for consistent behavior across environments.
    • Ensures identical formatting output regardless of local Python versions, reducing spurious diffs in pull requests.
    • Improves parity between local setups and CI, helping maintain a cleaner commit history.
    • No user-facing functionality changes; this affects developer workflow and code formatting only.

Signed-off-by: Jared Wilber <jwilber@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Walkthrough

Adds language_version: python3.9 to the mdformat hook in .pre-commit-config.yaml, configuring that hook to run under Python 3.9. No other settings or files are changed.

Changes

Cohort / File(s) Summary
Pre-commit hooks configuration
`.pre-commit-config.yaml`
Set `language_version: python3.9` for the `mdformat` hook under the mdformat repo entry; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A nibble on configs, hop-hop—so fine,
I set mdformat to Python three-nine.
Pre-commit burrows hum, checks align,
Carrots of syntax, tidy and divine.
Thump goes the tail—everything’s inline! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jwilber/force-mdformat-3.9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
.pre-commit-config.yaml (2)

29-29: Clarify PR intent: this pins the hook’s Python interpreter, not “mdformat version = 3.9.”

The change adds language_version: python3.9, which controls the interpreter used by the mdformat hook. The mdformat package version is already pinned by rev: 0.7.22. Please update the PR title/description to avoid confusion. Also, Line 26’s comment “Use the latest stable version” contradicts the explicit pin.


29-35: Ensure plugin compatibility under Python 3.9 or pin their versions.

additional_dependencies installs the latest mdformat-* plugins at hook-create time. If any drop 3.9 support, the hook will break under python3.9. Either:

  • Verify current releases of mdformat-tables, mdformat-gfm, mdformat-black, and mdformat-frontmatter support Py 3.9; or
  • Pin each to known-good versions compatible with 3.9.

I can help identify compatible versions and propose exact pins once you confirm the environments we must support.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7c18697 and 628c2bf.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (rust)

@pstjohn
Copy link
Collaborator

pstjohn commented Aug 28, 2025

/ok to test 628c2bf

Copy link
Collaborator

@pstjohn pstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we need this? do the rest of the hooks all run with python 3.9?
do we need to change the python version for the pre-commit step in .github/workflows/unit-tests-framework.yml?

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.70%. Comparing base (7c18697) to head (628c2bf).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   80.69%   80.70%           
=======================================
  Files         156      156           
  Lines       11060    11060           
=======================================
+ Hits         8925     8926    +1     
+ Misses       2135     2134    -1     

see 1 file with indirect coverage changes

@jwilber jwilber closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants