Conversation
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
WalkthroughAdds language_version: python3.9 to the mdformat hook in .pre-commit-config.yaml, configuring that hook to run under Python 3.9. No other settings or files are changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.pre-commit-config.yaml (2)
29-29: Clarify PR intent: this pins the hook’s Python interpreter, not “mdformat version = 3.9.”The change adds
language_version: python3.9, which controls the interpreter used by the mdformat hook. The mdformat package version is already pinned byrev: 0.7.22. Please update the PR title/description to avoid confusion. Also, Line 26’s comment “Use the latest stable version” contradicts the explicit pin.
29-35: Ensure plugin compatibility under Python 3.9 or pin their versions.
additional_dependenciesinstalls the latestmdformat-*plugins at hook-create time. If any drop 3.9 support, the hook will break underpython3.9. Either:
- Verify current releases of
mdformat-tables,mdformat-gfm,mdformat-black, andmdformat-frontmattersupport Py 3.9; or- Pin each to known-good versions compatible with 3.9.
I can help identify compatible versions and propose exact pins once you confirm the environments we must support.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.pre-commit-config.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (rust)
|
/ok to test 628c2bf |
pstjohn
left a comment
There was a problem hiding this comment.
LGTM, but do we need this? do the rest of the hooks all run with python 3.9?
do we need to change the python version for the pre-commit step in .github/workflows/unit-tests-framework.yml?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
=======================================
Coverage 80.69% 80.70%
=======================================
Files 156 156
Lines 11060 11060
=======================================
+ Hits 8925 8926 +1
+ Misses 2135 2134 -1 |
Fix mdformat version at 3.9
Summary by CodeRabbit