Skip to content

Change NeMo to new organization NVIDIA-NeMo.#1089

Merged
cspades merged 1 commit intomainfrom
cye/fix-nemo-remote
Aug 28, 2025
Merged

Change NeMo to new organization NVIDIA-NeMo.#1089
cspades merged 1 commit intomainfrom
cye/fix-nemo-remote

Conversation

@cspades
Copy link
Member

@cspades cspades commented Aug 28, 2025

Description

  • Update NeMo repository URL.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe):

CI Pipeline Configuration

Configure CI behavior by applying the relevant labels:

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Authorizing CI Runs

We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.

  • If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will
    automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
  • If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an
    /ok to test comment on the pull request to trigger CI. This will need to be done for each new commit.

Usage

$ cye@605b786-lcedt:~/Workspace/bionemo-framework$ cat .gitmodules
[submodule "3rdparty/Megatron-LM"]
        path = 3rdparty/Megatron-LM
        url = https://github.com/NVIDIA/Megatron-LM.git
[submodule "3rdparty/NeMo"]
        path = 3rdparty/NeMo
        url = https://github.com/NVIDIA-NeMo/NeMo.git
$ rm -drf 3rdparty/NeMo
$ mkdir 3rdparty/NeMo
$ cye@605b786-lcedt:~/Workspace/bionemo-framework$ ls -lah 3rdparty/NeMo
total 8.0K
drwxr-xr-x 2 cye domain-users 4.0K Aug 28 13:49 .
drwxr-xr-x 4 cye domain-users 4.0K Aug 28 13:49 ..
$ cye@605b786-lcedt:~/Workspace/bionemo-framework$ git submodule update
Submodule path '3rdparty/NeMo': checked out '7ccb0d4c5544dbcc454930acb3a1fe29d9db5090'
$ cye@605b786-lcedt:~/Workspace/bionemo-framework$ ls -lah 3rdparty/NeMo
total 408K
drwxr-xr-x 13 cye domain-users 4.0K Aug 28 13:50 .
drwxr-xr-x  4 cye domain-users 4.0K Aug 28 13:49 ..
-rw-r--r--  1 cye domain-users 137K Aug 28 13:50 CHANGELOG.md
-rw-r--r--  1 cye domain-users 1.1K Aug 28 13:50 CITATION.cff
-rw-r--r--  1 cye domain-users  563 Aug 28 13:50 codecov.yml
-rw-r--r--  1 cye domain-users 4.3K Aug 28 13:50 CONTRIBUTING.md
-rw-r--r--  1 cye domain-users  840 Aug 28 13:50 .coveragerc
drwxr-xr-x  3 cye domain-users 4.0K Aug 28 13:50 docker
-rw-r--r--  1 cye domain-users  184 Aug 28 13:50 .dockerignore
drwxr-xr-x  3 cye domain-users 4.0K Aug 28 13:50 docs
drwxr-xr-x 14 cye domain-users 4.0K Aug 28 13:50 examples
drwxr-xr-x  3 cye domain-users 4.0K Aug 28 13:50 external
-rw-r--r--  1 cye domain-users  305 Aug 28 13:50 .flake8
-rw-r--r--  1 cye domain-users  305 Aug 28 13:50 .flake8.other
-rw-r--r--  1 cye domain-users  306 Aug 28 13:50 .flake8.speech
-rw-r--r--  1 cye domain-users   41 Aug 28 13:50 .git
drwxr-xr-x  6 cye domain-users 4.0K Aug 28 13:50 .github
-rw-r--r--  1 cye domain-users 2.6K Aug 28 13:50 .gitignore
-rw-r--r--  1 cye domain-users  12K Aug 28 13:50 LICENSE
-rw-r--r--  1 cye domain-users   70 Aug 28 13:50 MANIFEST.in
drwxr-xr-x  9 cye domain-users 4.0K Aug 28 13:50 nemo
-rw-r--r--  1 cye domain-users 7.6K Aug 28 13:50 nemo_dependencies.py
-rw-r--r--  1 cye domain-users 1.8K Aug 28 13:50 .pre-commit-config.yaml
-rw-r--r--  1 cye domain-users   85 Aug 28 13:50 .pylintrc
-rw-r--r--  1 cye domain-users  225 Aug 28 13:50 .pylintrc.other
-rw-r--r--  1 cye domain-users  115 Aug 28 13:50 .pylintrc.speech
-rw-r--r--  1 cye domain-users 5.3K Aug 28 13:50 pyproject.toml
-rw-r--r--  1 cye domain-users  32K Aug 28 13:50 README.md
-rw-r--r--  1 cye domain-users 1.2K Aug 28 13:50 .readthedocs.yml
drwxr-xr-x  2 cye domain-users 4.0K Aug 28 13:50 requirements
drwxr-xr-x 35 cye domain-users 4.0K Aug 28 13:50 scripts
-rw-r--r--  1 cye domain-users  73K Aug 28 13:50 .secrets.baseline
-rw-r--r--  1 cye domain-users 9.8K Aug 28 13:50 setup.py
drwxr-xr-x 14 cye domain-users 4.0K Aug 28 13:50 tests
drwxr-xr-x 11 cye domain-users 4.0K Aug 28 13:50 tools
drwxr-xr-x 12 cye domain-users 4.0K Aug 28 13:50 tutorials

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

Summary by CodeRabbit

  • Chores
    • Updated the source reference for a third-party component to its current official repository to ensure reliable fetching and future updates.
    • Improves maintainability for development environments without altering application behavior.
    • No changes to features, performance, or user interface; builds and runtime functionality remain unaffected.

Signed-off-by: Cory Ye <cye@nvidia.com>
@cspades cspades self-assigned this Aug 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Walkthrough

Updated the Git submodule URL for NeMo in .gitmodules, switching the remote from github.com/NVIDIA/NeMo.git to github.com/NVIDIA-NeMo/NeMo.git. No other files or logic changed.

Changes

Cohort / File(s) Summary of Changes
Repo configuration: Submodule URL update
\.gitmodules
Changed NeMo submodule remote from https://github.com/NVIDIA/NeMo.git to https://github.com/NVIDIA-NeMo/NeMo.git; path remains 3rdparty/NeMo.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop to a new NeMo stream I see,
Git trails shift with nimble glee.
Burrow paths stay just the same,
Only the upstream changed its name.
Thump-thump, commit set free—
Carrot-approved dependency! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cye/fix-nemo-remote

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cspades cspades requested review from jwilber and yzhang123 August 28, 2025 19:45
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7c18697 and 5a4536b.

📒 Files selected for processing (1)
  • .gitmodules (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (rust)
🔇 Additional comments (1)
.gitmodules (1)

6-6: LGTM: NeMo submodule URL updated to the new org.

The remote now points to https://github.com/NVIDIA-NeMo/NeMo.git; path remains unchanged. Looks correct.

@cspades cspades enabled auto-merge August 28, 2025 20:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.69%. Comparing base (7c18697) to head (5a4536b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1089   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files         156      156           
  Lines       11060    11060           
=======================================
  Hits         8925     8925           
  Misses       2135     2135           

@cspades cspades added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit 157e7e8 Aug 28, 2025
36 of 37 checks passed
@cspades cspades deleted the cye/fix-nemo-remote branch August 28, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants