Skip to content

Draft: outline push-to-gitlab-registry step#830

Open
jwilber wants to merge 6 commits intomainfrom
jwilber/642-ci-push-to-gitlab-registry
Open

Draft: outline push-to-gitlab-registry step#830
jwilber wants to merge 6 commits intomainfrom
jwilber/642-ci-push-to-gitlab-registry

Conversation

@jwilber
Copy link
Collaborator

@jwilber jwilber commented Apr 14, 2025

Description

This corresponds to ticket https://jirasw.nvidia.com/browse/BIONEMO-642: add pushing images to gitlab registry from github actions.

Currently, it's a draft, as I don't have repo rights to add the required authentication tokens.

Changes:

  • Added new push-to-gitlab-registry job

With steps to:

  • debug info
  • login to docker
  • checkout repo
  • verify docker image tags from prev build step
  • check cpu architecture
  • once I've verified this works + have authentication, I'll add the buildx imagetools create step to publish

jwilber added 2 commits April 14, 2025 15:05
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
…er buildx imagetools create command

Signed-off-by: Jared Wilber <jwilber@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

jwilber added 2 commits April 14, 2025 15:53
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (4ab5a21) to head (ecdbade).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         137      137           
  Lines        8626     8626           
=======================================
  Hits         7276     7276           
  Misses       1350     1350           

jwilber added 2 commits April 14, 2025 17:05
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
exit 0
fi

push-to-gitlab-registry:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just add a tag to build-push-action? Maybe add a separate docker-metadata-action that only runs on push events if we want to get out the sha. I'm not sure we need to separate this out as a separate step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants