Open
Conversation
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
…er buildx imagetools create command Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 137 137
Lines 8626 8626
=======================================
Hits 7276 7276
Misses 1350 1350 |
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
pstjohn
reviewed
Apr 21, 2025
| exit 0 | ||
| fi | ||
|
|
||
| push-to-gitlab-registry: |
Collaborator
There was a problem hiding this comment.
Couldn't we just add a tag to build-push-action? Maybe add a separate docker-metadata-action that only runs on push events if we want to get out the sha. I'm not sure we need to separate this out as a separate step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This corresponds to ticket https://jirasw.nvidia.com/browse/BIONEMO-642: add pushing images to gitlab registry from github actions.
Currently, it's a draft, as I don't have repo rights to add the required authentication tokens.
Changes:
push-to-gitlab-registryjobWith steps to:
buildx imagetools createstep to publish