Set EXPERIMENTAL_1b_CHECKPOINT to True by default#840
Merged
Conversation
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
jstjohn
approved these changes
Apr 21, 2025
…ottom table value Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Collaborator
|
/build-tests |
Collaborator
Author
|
/ok to test 2d2f873 |
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Collaborator
Author
|
/ok to test 3bfebac |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 84.35% 84.32% -0.04%
==========================================
Files 139 139
Lines 8719 8719
==========================================
- Hits 7355 7352 -3
- Misses 1364 1367 +3 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2025
### Description Sets `EXPERIMENTAL_1b_CHECKPOINT` to True by default, so that AUC scores are good. Result for the new checkpoint are: | Data Fraction | FP8 On | FP8 Off | |---------------|--------|---------| | 0.05 | 0.73 | 0.77 | | 1 | 0.73 | 0.74 | @jstjohn this still keeps our other checkpoint. We could also optionally change the cell to something like below if we want to hide the original 1b checkpoint, or even update our `nemo2_evo2_1b_8k` checkpoint to use the new one bf16 ckpt. ```python %%capture MODEL_SIZE = "1b" # also try 7b if you have a GPU with more than 32GB of memory # Define checkpoint path if MODEL_SIZE == "1b": from bionemo.core.data.load import load # Always use the fine-tuned BF16 checkpoint for 1b model checkpoint_path = load("evo2/1b-8k-bf16:1.0") else: checkpoint_path = Path(f"nemo2_evo2_{MODEL_SIZE}_8k") # Check if the directory does not exist or is empty if not checkpoint_path.exists() or not any(checkpoint_path.iterdir()): !evo2_convert_to_nemo2 --model-path hf://arcinstitute/savanna_evo2_{MODEL_SIZE}_base --model-size {MODEL_SIZE} --output-dir nemo2_evo2_{MODEL_SIZE}_8k else: print("Checkpoint directory is not empty. Skipping command.") ``` ### Type of changes <!-- Mark the relevant option with an [x] --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest - [INCLUDE_SLOW_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_slow_tests) - Execute tests labelled as slow in pytest for extensive testing > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. * If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) * If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. ### Usage <!--- How does a user interact with the changed code --> ```python TODO: Add code snippet ``` ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [x] I have tested these changes locally - [x] I have updated the documentation accordingly - [x] I have added/updated tests as needed - [x] All existing tests pass successfully --------- Signed-off-by: Jared Wilber <jwilber@nvidia.com> Co-authored-by: John St. John <jstjohn@users.noreply.github.com>
trvachov
pushed a commit
that referenced
this pull request
May 16, 2025
### Description Sets `EXPERIMENTAL_1b_CHECKPOINT` to True by default, so that AUC scores are good. Result for the new checkpoint are: | Data Fraction | FP8 On | FP8 Off | |---------------|--------|---------| | 0.05 | 0.73 | 0.77 | | 1 | 0.73 | 0.74 | @jstjohn this still keeps our other checkpoint. We could also optionally change the cell to something like below if we want to hide the original 1b checkpoint, or even update our `nemo2_evo2_1b_8k` checkpoint to use the new one bf16 ckpt. ```python %%capture MODEL_SIZE = "1b" # also try 7b if you have a GPU with more than 32GB of memory # Define checkpoint path if MODEL_SIZE == "1b": from bionemo.core.data.load import load # Always use the fine-tuned BF16 checkpoint for 1b model checkpoint_path = load("evo2/1b-8k-bf16:1.0") else: checkpoint_path = Path(f"nemo2_evo2_{MODEL_SIZE}_8k") # Check if the directory does not exist or is empty if not checkpoint_path.exists() or not any(checkpoint_path.iterdir()): !evo2_convert_to_nemo2 --model-path hf://arcinstitute/savanna_evo2_{MODEL_SIZE}_base --model-size {MODEL_SIZE} --output-dir nemo2_evo2_{MODEL_SIZE}_8k else: print("Checkpoint directory is not empty. Skipping command.") ``` ### Type of changes <!-- Mark the relevant option with an [x] --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest - [INCLUDE_SLOW_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_slow_tests) - Execute tests labelled as slow in pytest for extensive testing > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. * If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) * If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. ### Usage <!--- How does a user interact with the changed code --> ```python TODO: Add code snippet ``` ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [x] I have tested these changes locally - [x] I have updated the documentation accordingly - [x] I have added/updated tests as needed - [x] All existing tests pass successfully --------- Signed-off-by: Jared Wilber <jwilber@nvidia.com> Co-authored-by: John St. John <jstjohn@users.noreply.github.com>
camirr-nv
pushed a commit
that referenced
this pull request
Jun 26, 2025
### Description Sets `EXPERIMENTAL_1b_CHECKPOINT` to True by default, so that AUC scores are good. Result for the new checkpoint are: | Data Fraction | FP8 On | FP8 Off | |---------------|--------|---------| | 0.05 | 0.73 | 0.77 | | 1 | 0.73 | 0.74 | @jstjohn this still keeps our other checkpoint. We could also optionally change the cell to something like below if we want to hide the original 1b checkpoint, or even update our `nemo2_evo2_1b_8k` checkpoint to use the new one bf16 ckpt. ```python %%capture MODEL_SIZE = "1b" # also try 7b if you have a GPU with more than 32GB of memory # Define checkpoint path if MODEL_SIZE == "1b": from bionemo.core.data.load import load # Always use the fine-tuned BF16 checkpoint for 1b model checkpoint_path = load("evo2/1b-8k-bf16:1.0") else: checkpoint_path = Path(f"nemo2_evo2_{MODEL_SIZE}_8k") # Check if the directory does not exist or is empty if not checkpoint_path.exists() or not any(checkpoint_path.iterdir()): !evo2_convert_to_nemo2 --model-path hf://arcinstitute/savanna_evo2_{MODEL_SIZE}_base --model-size {MODEL_SIZE} --output-dir nemo2_evo2_{MODEL_SIZE}_8k else: print("Checkpoint directory is not empty. Skipping command.") ``` ### Type of changes <!-- Mark the relevant option with an [x] --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest - [INCLUDE_SLOW_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_slow_tests) - Execute tests labelled as slow in pytest for extensive testing > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. * If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) * If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. ### Usage <!--- How does a user interact with the changed code --> ```python TODO: Add code snippet ``` ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [x] I have tested these changes locally - [x] I have updated the documentation accordingly - [x] I have added/updated tests as needed - [x] All existing tests pass successfully --------- Signed-off-by: Jared Wilber <jwilber@nvidia.com> Co-authored-by: John St. John <jstjohn@users.noreply.github.com> Signed-off-by: Ubuntu <camirr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets
EXPERIMENTAL_1b_CHECKPOINTto True by default, so that AUC scores are good.Result for the new checkpoint are:
@jstjohn this still keeps our other checkpoint. We could also optionally change the cell to something like below if we want to hide the original 1b checkpoint, or even update our
nemo2_evo2_1b_8kcheckpoint to use the new one bf16 ckpt.Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Usage
Pre-submit Checklist