Refactor cub::BlockLoadand cub::BlockStore#8120
Open
bernhardmgruber wants to merge 3 commits intoNVIDIA:mainfrom
Open
Refactor cub::BlockLoadand cub::BlockStore#8120bernhardmgruber wants to merge 3 commits intoNVIDIA:mainfrom
cub::BlockLoadand cub::BlockStore#8120bernhardmgruber wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
the PR is pretty big. Could you please add a brief summary of the changes in the description? |
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 5h 03m: Pass: 100%/249 | Total: 8d 17h | Max: 1h 46m | Hits: 59%/159565See results here. |
miscco
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
LoadInternalandStoreInternalpartial template specializations byif constexpr. Common code paths are de-duplicated. This leads to a lot more concise code.cub.test.block.load.it_11for SM120cub.test.block.store.it_11for SM120