Skip to content

Conversation

@a-mccarthy
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Documentation preview

https://nvidia.github.io/cloud-native-docs/review/pr-137

@mikemckiernan
Copy link
Member

Thanks for the fixups on the VMware typos! LGTM.

All the cloud-native projects require submitters to sign their commits--that's the DCO check. My recollection is that I used GPG to create a key, but it has been a while.

@mikemckiernan mikemckiernan added the documentation Issue/PR focused on fixing/editing/adding documentation bits label Dec 16, 2024
@a-mccarthy
Copy link
Collaborator Author

thanks @mikemckiernan! I'm working on getting my key set up for signing so i can fix the commit here

Signed-off-by: Abigail McCarthy <[email protected]>
@a-mccarthy
Copy link
Collaborator Author

@mikemckiernan, ok, i think i have the signing stuff straightened out!

Copy link
Member

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@mikemckiernan mikemckiernan merged commit 0951d57 into NVIDIA:main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue/PR focused on fixing/editing/adding documentation bits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants