Skip to content

Conversation

@mikemckiernan
Copy link
Member

This is a doozie to review. I suppose I can break it up into smaller parts if you find it a hassle to review.

@mikemckiernan mikemckiernan added the documentation Issue/PR focused on fixing/editing/adding documentation bits label Jan 17, 2025
@mikemckiernan mikemckiernan self-assigned this Jan 17, 2025
@github-actions
Copy link

Documentation preview

https://nvidia.github.io/cloud-native-docs/review/pr-142

@a-mccarthy
Copy link
Collaborator

Talked with @mikemckiernan about this PR. I think the changes look good.

Some notes on the changes:

  • The version picker is not working in the preview b/c it relies on a change to an internal repo that helps to build/publish the docs. This should not be an issue on the live site once everything is merged.
  • Updates to using a version1.json file instead of the current version.json file to align with the theme requirements. When we release a new version we only need to update the version1.json file for the new component.
  • The code block to create a table of contents is no longer needed for pages. This is handled automatically by the theme.

Signed-off-by: Mike McKiernan <[email protected]>
Signed-off-by: Mike McKiernan <[email protected]>
@mikemckiernan mikemckiernan merged commit 5c0b5eb into NVIDIA:main Jan 29, 2025
2 checks passed
@mikemckiernan mikemckiernan deleted the update-theme branch January 29, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue/PR focused on fixing/editing/adding documentation bits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants