Align container tags #151
Merged
Align container tags #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike McKiernan <[email protected]>
mikemckiernan
added
the
documentation
Documentation preview |
a-mccarthy
approved these changes
Jan 29, 2025
mikemckiernan
commented
Jan 29, 2025
Member
Author
mikemckiernan
left a comment
mikemckiernan
left a comment
There was a problem hiding this comment.
PLMK if I can clarify anything or if anything is concerning.
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: ${{ github.repository }} | ||
| TAG: 0.3.0 | ||
| TAG: 0.4.0 |
Member
Author
There was a problem hiding this comment.
I need to update this tag so that when it's merged the build noticed that 0.4.0 does not exist and builds the 0.4.0 image that has the updated theme and so on.
| CONTAINER_TEST_IMAGE: "${CI_REGISTRY_IMAGE}:${CI_COMMIT_REF_SLUG}" | ||
| CONTAINER_RELEASE_IMAGE: "${CI_REGISTRY_IMAGE}:0.5.0" | ||
| BUILDER_IMAGE: ghcr.io/nvidia/cloud-native-docs:0.2.0 | ||
| BUILDER_IMAGE: ghcr.io/nvidia/cloud-native-docs:0.4.0 |
Member
Author
There was a problem hiding this comment.
This needs to match the ghcr.io image so that the HTML is identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.