Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented May 17, 2024

No description provided.

@elezar elezar requested a review from mikemckiernan May 17, 2024 14:38
@elezar elezar self-assigned this May 17, 2024
Copy link
Member

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates appear to increase the scope of support and that's counter to my instincts--but you must have your reasons. PLMK what I can clarify and thank you.

## Linux Distributions

Supported Linux distributions are listed below:
The NVIDIA Container Toolkit has been qualified against the following platforms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect your choice of "qualified" rather than supported is to communicate some subtlety. If feels dicey to me, but it's you who answers questions and not me.

nit: s/has been/is/, unless there is a consideration that I'm overlooking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that people reach out to us all the time pointing out that we need to add "Debian 12" support or "Ubuntu 24.04" support, where we are reasonably confident that the packages should work as is. The caveat is that we have not officiallty tested against these configurations. If you have a suggestion on how to better call this out, that would be appreciated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jgehrcke jgehrcke Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great and important discussion. I wonder: what do we really do?

I see a contradiction between

we have not officially tested against these configurations

and

has been qualified

I see "qualification testing" as one of the later stages of testing in a release process, in particular meaning: I take a release candidate and make sure it works against all supported platforms.

edit: oh, I see. The table shows what in fact hast been properly qualification-tested.

You want to imply that we may support (in a loose understanding of the word) more than what is shown in the table.

Makes sense. Yeah we can try to put this into really simple words. Towards the community, it's typically important and sufficient to express the intent in a friendly tone. That removes much attack surface / source of frustration.

I will work on a proposal!

Comment on lines +21 to +24
Note that the installation packages are generally forward-compatible and the
omission of newer distributions from this list below does not indicate that the
NVIDIA Container Toolkit cannot be used there. Specific issues with newer
distributions should be reported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be rephrased more concisely.

NVIDIA Container Toolkit is generally forward compatible and works successfully on newer versions of the operating systems in the following table.

I've puzzled through the thought of directing readers to report issues from this section of the text, and I can't think why it's more compelling to urge that action here than in any other section. If you prefer to keep it, consider something like "Open an issue in the toolkit repository to report problems."

jgehrcke added a commit to jgehrcke/cloud-native-docs that referenced this pull request Feb 13, 2025
jgehrcke added a commit that referenced this pull request Feb 19, 2025
Notes:

- picking up the discussion from #62
- pull superscript into table heading, rewarp, renumber
- Centos -> CentOS
- Change heading: supported platforms -> platform support
  (because this page also talks about other distros)
- Remove "Linux Distributions" heading because there is no other category
- Review feedback: move bullet notes into subsections, one for each

Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
@jgehrcke
Copy link
Contributor

jgehrcke commented Feb 19, 2025

Great discussion. I think that after #159 we can close this. But this is certainly an area where we can and should do further optimization in the future.

@jgehrcke jgehrcke closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants