Use basis argument for Decomposition/BasisConversion passes#4211
Draft
lmondada wants to merge 2 commits intoNVIDIA:mainfrom
Draft
Use basis argument for Decomposition/BasisConversion passes#4211lmondada wants to merge 2 commits intoNVIDIA:mainfrom
lmondada wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Collaborator
Author
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an old outstanding task following #3644. There is now a simpler 'declarative' way of defining which basis gates to decompose to, without having to explicitly list all patterns.
enable-patternslists with thebasisargument in Decomposition pass usage across 5 target YAML files (braket, scaleway, tii, infleqtion, quantum_machines) and the OpenQASM pipelinedisable-patterns=R1ToU3from all 8 BasisConversion pipeline definitions, as the pattern selection algorithm (introduced in Add Decomposition Pattern Selection logic #3644) handles this automaticallydisable-patterns=R1ToU3from BasisConversion test RUN linesThe pattern selection algorithm selects decomposition patterns via backward traversal of a decomposition pattern graph, choosing the shortest path to the target basis. This makes manually curating pattern lists unnecessary.