Skip to content

Use basis argument for Decomposition/BasisConversion passes#4211

Draft
lmondada wants to merge 2 commits intoNVIDIA:mainfrom
lmondada:lm/use-basis-decomp
Draft

Use basis argument for Decomposition/BasisConversion passes#4211
lmondada wants to merge 2 commits intoNVIDIA:mainfrom
lmondada:lm/use-basis-decomp

Conversation

@lmondada
Copy link
Copy Markdown
Collaborator

This was an old outstanding task following #3644. There is now a simpler 'declarative' way of defining which basis gates to decompose to, without having to explicitly list all patterns.

  • Replace explicit enable-patterns lists with the basis argument in Decomposition pass usage across 5 target YAML files (braket, scaleway, tii, infleqtion, quantum_machines) and the OpenQASM pipeline
  • Remove redundant disable-patterns=R1ToU3 from all 8 BasisConversion pipeline definitions, as the pattern selection algorithm (introduced in Add Decomposition Pattern Selection logic #3644) handles this automatically
  • Remove disable-patterns=R1ToU3 from BasisConversion test RUN lines

The pattern selection algorithm selects decomposition patterns via backward traversal of a decomposition pattern graph, choosing the shortest path to the target basis. This makes manually curating pattern lists unnecessary.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 24, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@lmondada
Copy link
Copy Markdown
Collaborator Author

lmondada commented Mar 24, 2026

/ok to test ade6a82

Command Bot: Processing...

@github-actions
Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant