Forward-merge release/25.12 into main #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes:
```
=================================================================
==1254203==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 12608 byte(s) in 394 object(s) allocated from:
#0 0x7e3eb66b1cba in malloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x7e3e94e7a10d in cudss_host_malloc(unsigned long, unsigned long) (/home/hugo/miniforge3/envs/cuopt_dev/lib/libcudss.so.0+0x7a10d) (BuildId: 32758b1c028e396ecb7d0a0feb68940b94db8738)
Direct leak of 6240 byte(s) in 195 object(s) allocated from:
#0 0x7e3eb66b1cba in malloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x7e3e99deb2f0 (/home/hugo/miniforge3/envs/cuopt_dev/lib/libcusparse.so.12+0xbeb2f0) (BuildId: 3ddaf480ddd8ee4af8596e8e2a712ea0a65dc692)
Indirect leak of 40976 byte(s) in 394 object(s) allocated from:
#0 0x7e3eb66b1cba in malloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x7e3e94e7a10d in cudss_host_malloc(unsigned long, unsigned long) (/home/hugo/miniforge3/envs/cuopt_dev/lib/libcudss.so.0+0x7a10d) (BuildId: 32758b1c028e396ecb7d0a0feb68940b94db8738)
SUMMARY: AddressSanitizer: 59824 byte(s) leaked in 983 allocation(s).
```
## Summary by CodeRabbit
* **Refactor**
* Added a scoped RAII wrapper for GPU dense-vector handles and updated public APIs to use it instead of raw descriptors.
* Moved resource cleanup into destructors and narrowed vector creation sites to simplify initialization and runtime flow.
* Removed redundant per-solve recreation of certain GPU structures.
* **Bug Fixes**
* Made descriptor destruction conditional to avoid teardown errors and leaks.
* Added a non-throwing GPU API error-reporting path to improve stability.
Authors:
- Hugo Linsenmaier (https://github.com/hlinsen)
- Jake Awe (https://github.com/AyodeAwe)
Approvers:
- Rajesh Gandham (https://github.com/rg20)
- Ramakrishnap (https://github.com/rgsl888prabhu)
URL: #584
Contributor
Author
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/25.12 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.